Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppLocker PowerShell reference update #2623

Merged

Conversation

TimShererWithAquent
Copy link
Contributor

@TimShererWithAquent TimShererWithAquent commented Sep 1, 2021

1871144

I updated an example to use the new param. I didn't follow guidance on omitting the prompt (or make any other changes to the example) for consistency with the other two examples.

@opbld30
Copy link

opbld30 commented Sep 1, 2021

Docs Build status updates of commit f785606:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/applocker/New-AppLockerPolicy.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@TimShererWithAquent
Copy link
Contributor Author

Getting feedback on new text now.

@opbld30
Copy link

opbld30 commented Sep 2, 2021

Docs Build status updates of commit 06509e3:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/applocker/New-AppLockerPolicy.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@TimShererWithAquent
Copy link
Contributor Author

Text approved by product team in email. Ready for review.

@TimShererWithAquent TimShererWithAquent marked this pull request as ready for review September 2, 2021 19:39
@TimShererWithAquent TimShererWithAquent changed the title WIP: AppLocker PowerShell reference update AppLocker PowerShell reference update Sep 2, 2021
Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy review.

@TimShererWithAquent
Copy link
Contributor Author

@tiburd - This is ready for review.

@tiburd tiburd requested review from get-itips, dariomws and a user September 13, 2021 20:38
@tiburd tiburd assigned o0nj, ghost , dariomws and get-itips Sep 13, 2021
Copy link
Contributor

@get-itips get-itips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as my comment


```yaml
Type: SwitchParameter
Parameter Sets: FileInformation
Copy link
Contributor

@get-itips get-itips Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if adding two yaml blocks under the parameter is the correct way or specifying

Parameter Sets: (All)

like other cmdlet articles do, I do know that one specifies required true and the other false... @dariomws @tseward ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Maybe the best way is using Parameter Sets: (All). And looking over the other example it seems that this parameter is not required.

Copy link
Contributor

@dariomws dariomws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @get-itips.

@opbld33
Copy link

opbld33 commented Sep 14, 2021

Docs Build status updates of commit 7f4aec5:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/applocker/New-AppLockerPolicy.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@o0nj o0nj added the Sign off The pull request is ready to be reviewed and merged by PubOps label Sep 14, 2021
@garycentric garycentric self-assigned this Sep 14, 2021
@garycentric garycentric added the In review PubOps is reviewing the pull request label Sep 14, 2021
@opbld33
Copy link

opbld33 commented Sep 14, 2021

Docs Build status updates of commit d4ae35b:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/applocker/New-AppLockerPolicy.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@garycentric garycentric merged commit 88f1db1 into MicrosoftDocs:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In review PubOps is reviewing the pull request Microsoft submitter Sign off The pull request is ready to be reviewed and merged by PubOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants