Update URI for the authenticationmethod claim #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct URI for the schemas.microsoft.com/ws/2008/06/identity/claims/authenticationmethod claim type in the TryEndAuthentication should use http; not https. Else, it generates errors like so. Event Xml: <Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event"> <System> <Provider Name="AD FS Tracing" Guid="{0457a490-4d4d-4a5b-b639-35382f1b6709}" /> <EventID>153</EventID> <Version>0</Version> <Level>2</Level> <Task>0</Task> <Opcode>0</Opcode> <Keywords>0x8000000004000000</Keywords> <TimeCreated SystemTime="2020-04-09T11:48:40.595457400Z" /> <EventRecordID>1909</EventRecordID> <Correlation ActivityID="{e77f758c-6fdf-4a95-9201-0080000000ff}" /> <Execution ProcessID="9812" ThreadID="9284" ProcessorID="3" KernelTime="308" UserTime="2061" /> <Channel>ad fs tracing/debug</Channel> <Computer>maweer454VM.maweeras1.lab</Computer> <Security UserID="S-1-5-21-3539614737-2601322808-1240387331-1113" /> </System> <UserData> <Event xmlns="http://schemas.microsoft.com/ActiveDirectoryFederationServices/2.0/Events"> <EventData>Exception: The authentication provider did not return an authentication method claim. StackTrace: at Microsoft.IdentityServer.Web.Authentication.External.ExternalAuthenticationHandler.ValidateAdapterClaims(IAuthenticationContext authContext, ICollection`1 claims, Int32 responseLcid) at Microsoft.IdentityServer.Web.Authentication.External.ExternalAuthenticationHandler.ProcessAdapterClaims(ICollection`1 claims, AuthenticationContext authContext, ProtocolContext context, IAccountStoreUserData userData) at Microsoft.IdentityServer.Web.Authentication.External.ExternalAuthenticationHandler.Process(ProtocolContext context) at Microsoft.IdentityServer.Web.Authentication.AuthenticationOptionsHandler.Process(ProtocolContext context) at Microsoft.IdentityServer.Web.PassiveProtocolListener.OnGetContext(WrappedHttpListenerContext context) </EventData> </Event> </UserData> </Event>
|
@billmath Please confirm for merging. |
|
@maweeras-msft : I noticed that the source page formatting leaves a lot to be desired in terms of proper view of many sections in the resulting page. I would like to have a go at improving it, but I also want to wait for this PR to be merged first. Would you be so kind as to ping me (@illfated ) when the merge is complete? (I will do my best to follow the development here, so no big deal if you are too busy.) |
|
#sign-off |
learn-build-service-prod bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
8/8/2023 10:30 AM Publish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct URI for the schemas.microsoft.com/ws/2008/06/identity/claims/authenticationmethod claim type in the TryEndAuthentication should use http; not https. Else, it generates errors like so.
Event Xml:
153
0
2
0
0
0x8000000004000000
1909
ad fs tracing/debug
maweer454VM.maweeras1.lab
Exception: The authentication provider did not return an authentication method claim.
StackTrace: at Microsoft.IdentityServer.Web.Authentication.External.ExternalAuthenticationHandler.ValidateAdapterClaims(IAuthenticationContext authContext, ICollection
1 claims, Int32 responseLcid) at Microsoft.IdentityServer.Web.Authentication.External.ExternalAuthenticationHandler.ProcessAdapterClaims(ICollection1 claims, AuthenticationContext authContext, ProtocolContext context, IAccountStoreUserData userData)at Microsoft.IdentityServer.Web.Authentication.External.ExternalAuthenticationHandler.Process(ProtocolContext context)
at Microsoft.IdentityServer.Web.Authentication.AuthenticationOptionsHandler.Process(ProtocolContext context)
at Microsoft.IdentityServer.Web.PassiveProtocolListener.OnGetContext(WrappedHttpListenerContext context)