-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime 100.0.1185.29: Crash of Office application when dialog opens from VSTO Add-in with WebView2 using HostObject #2337
Comments
I have similar issue with Outlook VSTO Add-in.
|
Just to add - it started happening after some recent runtime update. I tested with Fixed version 99.0.1150.55 and the issue was not there. |
We're observing the same behaviour as well, we open a popup for (OAuth2) authentication-flow, this goes through a few redirects and then automatically closes. |
@champnic, we have issue in production with high impact. |
Hey all - thanks for bringing this to our attention. I've opened this as a P0 bug on our team and we'll dig into this right away. I'll let you know when I know more. Thanks! |
Hi @estet , is this for an existing public add-in or one that's in development? If this is one in development, could upload a VS solution that reproes this crash so I can take a look and otherwise point me to the public add-in I can repro the crash from? Thanks! |
We believe this may be caused by changes in the code for handling host object method calls ( |
Hi @yildirimcagri, |
We have the issue root caused and are testing out a fix now. Assuming it resolves the issue, we'll get it checked in and then it should rollout soon, over the next few days (I'll try and get a better timeline). |
We're still looking for an Office add-in or other sample app that is reproducing the problem so that we can verify we have actually fixed your problem. Please let me know if you have something you are able to share. |
@champnic we are preparing a sample |
@champnic @yildirimcagri Sample is ready here https://github.com/estet/WebView2AddinCrashSample |
Following this issue. We are also affected by this issue... Major crash now with all of our customers who received the 100.0 upgrades! No issues with 99.0. Similar flow to what was described by @MysteriousGreenBean and @avaneerd above. We have an Outlook VSTO Add-in with a popup for OAuth and use HostObject/Scripting ... a few redirects and Outlook crashes. |
@champnic - if you are looking for another Outlook add-in to test a fix, our release package is public and could be relatively easy to test. |
@StephaneZ that sounds very much like what we experience, you can check the sample I added. |
Thanks a bunch for the repro @estet! We have the fix checked in and are working on bringing it back to the previous releases (100 and 101). I'm checking with our release team to see if we can fast-track another 100 release. @StephaneZ If you could share your public repro as well that would be helpful! |
@estet could you look at the "Windows Error Reporting" events after the Application Error event and share the "Hashed bucket" value from those events? That would help the investigation. |
@champnic Once fix is released what is the best way for customers to get the latest version. Thanks for getting this out quickly. |
@estet We're having trouble getting your repro to crash in the way described in this thread. When we click the "crash me" button there's an expected debugbreak for re-entrancy, but that only fires when we have the debugger attached, and is related to the fact that it is calling "ShowDialog" from within a WebView2 call. @StephaneZ Just checking again to see if you can share the public repro you mentioned? @avaneerd / @MysteriousGreenBean - Do you have a way for us to reproduce the issue? We have checked in what we think is a fix (and at least fixes #2333) but we haven't been able to verify it for this issue yet. The fix should be available in tomorrow's Canary build and so you'll all be able to try it on your own machines and setups. Thanks! |
@LiangTheDev I only have this:
|
@LiangTheDev I find this "Windows Error Reporting" Entry:
|
@champnic it is easier when VSTO add-in runs in debug (at least for me), also you need to wait a bit longer (up to 30 seconds) also disable all the break points. |
Also where to get canary webView2 runtime? To verify the fix |
The hashed bucket provided by @avaneerd matches up to the issue that we checked in a fix for yesterday, so the fix should indeed resolve this issue. The fix is included in the latest release of Edge Canary from a few hours ago, version 102.0.1220.0. To test your app against Edge Canary you'll need to have it installed (and updated to at least that version) and then follow these instructions. An easy way to verify which runtime your app is using is to observe the corresponding msedgewebview2.exe processes in the Details tab of Task Manager; turn on the Command Line column and check the exe's path. The fix has also gone into the 101.* (currently in Dev) and 100.* (currently in Stable and Beta) branches but isn't yet included in any releases from them because those releases are slower. |
@estet In your sample there is a WV2 containing JavaScript that calls a .NET host object method, which invokes a modal (synchronous/blocking) dialog box that contains a second WV2. Does your real add-in also invoke a modal WV2 dialog box from inside a host object method called by a different WV2? If so, was that working okay with earlier runtimes (e.g. 99)? For anyone else experiencing this issue (e.g. @StephaneZ), does your app/add-in do the same thing? |
Our team just retested with the Canary release. Initial testing looks good. 👍 Thank you to the whole team for the quick turnaround time. Any indications on rollout timing? We have thousands of end users that either are or about to be impacted. |
Regarding your previous question about having multiple WV2 components sharing a host object... I'll have to confirm. We have our installer publicly available and can provide test app credentials details in DM. |
@StephaneZ Rollout will be around next Thurs for the 100 release. We're currently investigating if we can speed up that process. If you could email me the installer info for your scenario to |
@champnic We have the same issue with a plugin from a supplier. They advise to downgrade to 99.0.1150.55. |
Hi @champnic, I just tested it with our actual application and there it seems to work. So there probably is some other issue in the demo project we provided. So the fix seems to work! @AndyT-MS our add-in does indeed invoke a modal WV2 dialog box from inside a host object method called by a different WV2 and this was working fine before. |
@nickdekesel Glad to hear the fix is working! @drlandau This Thursday, 4/14. |
@champnic Is this fix available in 101.0.1210.53? |
@NataliaKravcheniaTR Yes, that version should have the fix. |
Description
Starting with version 100.0.1185.29(Evergreen) Powerpoint VSTO Add-in crashes when open Form with webView2 on it
Application Error:
=========
Version
SDK: 1.0.1150.38/1.0.1054.31
Runtime: 100.0.1185.29
Framework: WinForms
OS: Win10, Office 365 (Version 2203 Build 16.0.15028.20152) 64-bit
Repro Steps
Call
Form.ShowDialog
with WebView2 Component on it via Host Object (VSTO)Navigate to a page with several redirects (f.e. authentication provider, tried on MS sharepoint)
Expected behavior: Successfully navigate to a page like in previous version of WebView2.
Actual behavior: After first/second redirect getting several ConnectionAborted in NavigationCompleted event and crash of PowerPoint without any exceptions thrown.
Screenshots
Additional context
AB#38875823
The text was updated successfully, but these errors were encountered: