Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In edge://downloads/all is "downloads settings" intended and issue in downloads where DownloadStarting is implemented? #2753

Closed
darbid opened this issue Sep 5, 2022 · 4 comments
Assignees
Labels
tracked We are tracking this work internally.

Comments

@darbid
Copy link

darbid commented Sep 5, 2022

I hope to use edge://downloads/all, however I have noticed 2 small things. see below image.

downloads

The "open downloads folder" opens the standard windows "downloads" folder. I however have downloads being saved elsewhere.

The three little dots open the downloads settings which opens a new window and then displays nothing.

Are both of these things intended?

AB#41248958

@vickiez
Copy link
Contributor

vickiez commented Sep 8, 2022

Hi @darbid, I haven't been able to repro the first issue. Are you using the default download path API?

The second issue does sound like a bug in WebView2, I will open a work item to track the fix. Thanks!

@vickiez vickiez added the tracked We are tracking this work internally. label Sep 8, 2022
@darbid
Copy link
Author

darbid commented Sep 12, 2022

Hi @darbid, I haven't been able to repro the first issue. Are you using the default download path API?

The second issue does sound like a bug in WebView2, I will open a work item to track the fix. Thanks!

Hi Vickiez,

Thanks for looking at this. With respect to "open downloads folder" you are correct, my bad, the folder path was on its default value.

@darbid darbid changed the title In edge://downloads/all is "open downloads folder" and "downloads settings" intended? In edge://downloads/all is "downloads settings" intended and issue in downloads where DownloadStarting is implemented? Sep 12, 2022
@darbid
Copy link
Author

darbid commented Sep 12, 2022

@vickiez I have also noticed another minor issue/bug.

  1. view a pdf in the default pdf viewer
  2. save the pdf using the save button
  3. open edge://downloads/all
  4. the pdf is shown in the download list

1a. implement DownloadStarting
2a. No need to make any changes to ResultFilePath, simple set e.Handled = true;
3a. now repeat the above steps 1-3
4a. the pdf is not shown in the list

If I stop my app and restart it and then look at edge://downloads/all then the pdf from steps 1a-3a is listed.

@champnic
Copy link
Member

The original issue should be resolved in runtimes version 107.0.1383.0+.

@darbid Can you open the additional bug as a new GH issue? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracked We are tracking this work internally.
Projects
None yet
Development

No branches or pull requests

3 participants