Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreWebView2.Settings.HiddenPdfToolbarItems: When hidingBookmarks, Search and PageSelector the toolbar gets lost #2866

Closed
irgendwienet opened this issue Oct 11, 2022 · 14 comments
Assignees
Labels
bug Something isn't working tracked We are tracking this work internally.

Comments

@irgendwienet
Copy link

irgendwienet commented Oct 11, 2022

Description

With the following configuration one can hide buttons in the pdf toolbar.

        wv.CoreWebView2.Settings.HiddenPdfToolbarItems =
            | CoreWebView2PdfToolbarItems.Bookmarks
            | CoreWebView2PdfToolbarItems.Search
            | CoreWebView2PdfToolbarItems.PageSelector

When only hiding one or two of theses (!) 3 buttons the buttons are hidden and everything works as expected.

But when trying to hide all these 3 buttons (but keep e.g. zoom and print visible) the whole toolbar just becomes invisible and no button at all is usable.

Version
SDK: 1.0.1414-prerelease and 1.0.1370.28 (from nuget.org)
Runtime: Microsoft Edge Version 106.0.1370.37 (Official build) (64-bit)
Framework: WPF
OS: Win10 Version 10.0.19044 Build 19044

Screenshots

When search button is not hidden:

image

Same config but only search should be hidden:

image

whole toolbar is missing

Additional context

AB#41952917

@irgendwienet irgendwienet added the bug Something isn't working label Oct 11, 2022
@victorthoang
Copy link

Hello @irgendwienet,

Thanks for your bug report. I've assigned this to a dev that can best try to replicate the issue and follow up on this.

@imicy imicy assigned ElyssaJyu and unassigned imicy Oct 24, 2022
@ElyssaJyu
Copy link

Hi @irgendwienet, it looks fine when only hiding Search bottom.
image
Hiding Search bottom:
image

But there is an issue that the whole toolbar becomes invisible when hiding these three bottoms simultaneously. I will investigate it and let you know later.

@ElyssaJyu ElyssaJyu added the tracked We are tracking this work internally. label Oct 26, 2022
@ElyssaJyu
Copy link

This has been fixed. Thanks!

@champnic
Copy link
Member

The fix is available in runtime versions 109.0.1474.0+.

@ivicamil
Copy link

Runtime version 111.0.1661.44 broke this for me again. Trying to hide Bookmarks, makes the entire toolbar disappear.

@ElyssaJyu
Copy link

Hey @ivicamil, sorry for breaking your work. I will figure it out and sync with you when the fix is updated.

@irgendwienet
Copy link
Author

I'm now using runtime version 114.0.1823.37 and it seems to me like broken again.

But now I see the following behavior:

  • When specifying CoreWebView2PdfToolbarItems.Bookmarks the whole toolbar disappears. It does not matter if specifying this value alone or in combination with others.
  • CoreWebView2PdfToolbarItems.FullScreen seems to have no effect at all.
  • Maybe CoreWebView2PdfToolbarItems.MoreSettings does not have an effect. (maybe I'm wrong with this one.)

@champnic champnic reopened this Jun 7, 2023
@champnic
Copy link
Member

champnic commented Jun 7, 2023

I've just reopened this issue and corresponding bug to take another look. @ElyssaJyu FYI

@champnic
Copy link
Member

champnic commented Jun 7, 2023

I see @ElyssaJyu put in a change recently. This should be fixed in runtimes 115.0.1850.0+. Can you give that a try and see if you still see the issue?

@champnic champnic closed this as completed Jun 7, 2023
@ElyssaJyu
Copy link

Hi @irgendwienet, CoreWebView2PdfToolbarItems.Bookmarks causes the blank toolbar will be fixed in runtime 115.0.1850.0+. I will take a look on No effect on MoreSettings and FullScreen. Thanks.

@O4D
Copy link

O4D commented Jul 7, 2023

Hi @irgendwienet, CoreWebView2PdfToolbarItems.Bookmarks causes the blank toolbar will be fixed in runtime 115.0.1850.0+. I will take a look on No effect on MoreSettings and FullScreen. Thanks.

Hello. Can you help me to understand what does it means about the fix in the WebView2 nuget extension ?
I downloaded the last package version (WebView2.1.0.1823.32) for a .NET project but this issue still occurs.

@ElyssaJyu
Copy link

ElyssaJyu commented Jul 7, 2023

Hi @O4D,
the WebView2 package from NuGet is to add webview2 SDK(WebView2.1.0.1823.3) to your project. It doesn't contain webview2 runtime. Could you check which version of webview2 runtime are you using?
The stable WebView2 path is "C:\Program Files (x86)\Microsoft\EdgeWebView\Application"
The default Edge Canary channel path is "C:\Users\yourname\AppData\Local\Microsoft\Edge SxS\Application";

The webview2 runtime updates automatically, which receives the same Microsoft Edge updated. Currently, the webview2 runtime release version should be 114.0.1823.67. Runtime 115+ will be released soon. This page will give more details about WebView2 runtime.

Or you can switch to a preview channel to test upcoming feature. Thanks.

@champnic
Copy link
Member

champnic commented Jul 7, 2023

Slight clarification - the stable WebView2 runtime is installed here (and you can also check "Programs and Features" settings for the current version of installed WebView2):
C:\Program Files (x86)\Microsoft\EdgeWebView\Application

The path @ElyssaJyu provided is if you are using the Edge Canary channel as the runtime:
C:\Users\<username>\AppData\Local\Microsoft\Edge SxS\Application

@IsaiahMcAdam
Copy link

I experience the toolbar disappearing upon hiding CoreWebView2PdfToolbarItems.Bookmarks alone or while hiding other items with CoreWebView2PdfToolbarItems.Bookmarks.

EdgeWebView version: 121.0.2277.128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tracked We are tracking this work internally.
Projects
None yet
Development

No branches or pull requests

8 participants