Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTA to install Chrome extensions is visible #3312

Open
q71114 opened this issue Mar 16, 2023 · 9 comments
Open

CTA to install Chrome extensions is visible #3312

q71114 opened this issue Mar 16, 2023 · 9 comments
Assignees
Labels
bug Something isn't working tracked We are tracking this work internally.

Comments

@q71114
Copy link

q71114 commented Mar 16, 2023

Description
When visiting Chrome extension store Edge related banner is displayed with CTA to allow extensions from Chrome store.

Version
SDK: 1.0.1671-prerelease
Runtime: Evergreen, 110.0.1587.69
Framework: WPF
OS: Win11

Repro Steps

  1. Navigate to https://chrome.google.com/webstore/detail/google-translate/aapbdbdomjkkjkaonfhkkikfgjllcleb

Expected: No CTA banner is displayed.
Actual: CTA banner to allow extensions from Chrome store is displayed.

Screenshots
image
image

Additional context
Allow extensions from other stores button can be clicked which opens a native popup.

AB#49821879

@q71114 q71114 added the bug Something isn't working label Mar 16, 2023
@q71114 q71114 changed the title Remove CTA to Remove CTA to install Chrome extensions Mar 16, 2023
@q71114 q71114 changed the title Remove CTA to install Chrome extensions CTA to install Chrome extensions is visible Mar 16, 2023
@novac42
Copy link
Contributor

novac42 commented Mar 17, 2023

Thanks for reporting the issue. I've assigned this to a dev who can help follow up on this.

@champnic champnic added the tracked We are tracking this work internally. label Mar 30, 2023
@champnic
Copy link
Member

Thanks for the bug report @q71114! We'll get this fixed, I've opened it as a bug on our backlog.

@Master-Ukulele
Copy link

Thanks for reporting, it's been fixed recently. Please check it out in sdk 1.0.1777-prerelease.

@champnic
Copy link
Member

Fix is in WebView2 runtimes 114.0.1784.0+. Thanks!

@deanmalone
Copy link

@champnic @Master-Ukulele Can this issue be re-opened please?

We are seeing a regression of this issue in version 119.0.2151.44. Noting that the regression may have occurred earlier as we only just recently noticed it.

@Master-Ukulele
Copy link

Thanks @deanmalone, we will take a look.

@Master-Ukulele
Copy link

@deanmalone Hi, I didn't repro to see the banner. Can you check if it's still a problem? However, I saw the chrome web store page has a button that can open the "allow extension from other stores" dialog. Is this the issue you talking about?

@pdolanjski
Copy link

@Master-Ukulele , there are a few issues here:

  1. A user can click to install an extension which will bring up the "allow extension from other stores" dialog. We wouldn't expect that dialog come up at all.
  2. If the user clicks Allow, then they get another dialog to confirm the addition of the add-on. This refers to Edge, which isn't relevant here and the dialog doesn't make sense because it won't actually do anything.

Because of the above, this is highly confusing for our app's users since it erroneously uses an Edge dialog and makes them believe that they will be able to install and use these extensions, but they can't.

@Master-Ukulele
Copy link

Thanks for reporting. We see the access from banner is disabled. But the access from the button "add to chrome/get" become reactive now. We will try to block "allow extension from other stores" dialog completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tracked We are tracking this work internally.
Projects
None yet
Development

No branches or pull requests

6 participants