Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationCompleted regression for certain websites #3801

Closed
lezzi opened this issue Sep 20, 2023 · 8 comments
Closed

NavigationCompleted regression for certain websites #3801

lezzi opened this issue Sep 20, 2023 · 8 comments
Assignees
Labels
bug Something isn't working tracked We are tracking this work internally.

Comments

@lezzi
Copy link

lezzi commented Sep 20, 2023

Description
The CoreWebView2.NavigationCompleted event stopped raising for some websites. It can be reproduced by navigating to https://www.tradingview.com/.

Version
SDK: 1.0.1722.45, 1.0.1988-prerelease
Runtime: 117.0.2045.31, 117.0.2045.36.
Framework: WPF
OS: Windows 11 Pro 22H2 22621.1992

Regression

  • Last time it worked properly on the 116.0.1938.81 runtime.
  • It works on the latest Canary 119.0.2111.0 runtime.

Repro Steps

  1. Download and install the Evergreen 117.0.2045.36 runtime (link).
  2. Clone the official WebView2WpfBrowser.
  3. Start the browser and navigate to https://www.tradingview.com/.

Expected: The "Reload" button gets enabled after the site has loaded.
Actual: The "Reload" button stays disabled forever and "Waiting for {url}..." can be visible in the left bottom corner.

image

Additional context

  • There are no pending requests on the Dev Tools Network page
  • The issue does not exist on the 116.0.1938.81 runtime and older versions.
  • The issue looks to be fixed in the latest Canary.

AB#46853226

@lezzi lezzi added the bug Something isn't working label Sep 20, 2023
@RendijsSmukulis
Copy link

I've just checked that it's not just WebView2 that presents this regression, but Edge also never finishes loading the page:

  • It repros on latest Edge (117.0.2045.36)
  • It repros on latest Edge Canary (119.0.2115.0)
  • Chrome or Firefox finish loading the page as expected.

@peiche-jessica peiche-jessica added the tracked We are tracking this work internally. label Oct 4, 2023
@monica-ch
Copy link
Contributor

monica-ch commented Oct 13, 2023

@lezzi Looks like this site is using AV1 encoding to play the video and Edge requires AV1 Video Extension to play AV1(In Edge 117, we stopped to support AV1) which might be causing the issue. Can you make sure you install AV1 video extension for it to work? Also be sure to clear the browser /wv2 cache after the installation.

Let me know if this works

@MarkIngramUK
Copy link

MarkIngramUK commented Oct 18, 2023

Can you make sure you install AV1 video extension for it to work?

@monica-ch , we are building a browser, and aren't in control of the websites that our users navigate to. We really need to know what functionality is being removed (and APIs stop working as a result) as it has severe consequences for us.

@RendijsSmukulis
Copy link

@monica-ch It does indeed look like the AV1 support, I see AV1 videos no longer work in our app.

Can you please clarify the "install AV1 video extension" step, as I've installed the https://apps.microsoft.com/detail/av1-video-extension/9MVZQVXJBQ9V?hl=en-gb&gl=LV extension and it did not resolve the issue for Edge or our app. The page still never finishes loading, and the videos don't play. Even after clearing out the WV2 profile folders.

@monica-ch
Copy link
Contributor

@RendijsSmukulis Can you send the logs from about://media-internals both from browser and wv2 app, please close microsoft edge and wv2 app first then repro it and send the logs

@monica-ch
Copy link
Contributor

@MarkIngramUK Edge and WebView2 have never broadly support AV1. The ability to leverage the Windows codec pack version of AV1 has been considered experimental and many users have never had the AV1 codec pack installed on their device. The experimental support was impacted due to upstream re-architecture for video decoding on Windows but, since it’s considered experimental and never broadly available, it was not noted in release notes. We are exploring options to re-enable the experimental codec pack support and can share updates if and when we have them.

cc @nishitha-burman

@monica-ch
Copy link
Contributor

@lezzi @RendijsSmukulis See above comment, we are exploring options to re-enable the experimental codec pack support to play av1 videos and I'll update the thread once we have info.

@monica-ch
Copy link
Contributor

AV1 encoding is now supported in Edge 121+ which also fixed the navigation issue in WebView2. Please test in WebView2 app using Edge Beta binaries and let us know if you still see any issues.

Closing the thread, feel free to re-open if you see any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tracked We are tracking this work internally.
Projects
None yet
Development

No branches or pull requests

6 participants