-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Stop() method #28
Comments
Thanks for the feedback! Sounds reasonable to me that you'd want a cancel/stop functionality outside of the navigationStarting event. We will look into it. If you don't mind me asking, what are you planning to build with WebView? |
We have a couple of desktop products that use WebViews for part of the UI, and for capturing page thumbnails. On Windows we've used MsHtml since IE 3.0 was released, and on Mac we use the WebKit Framework. We're planning to migrate the Windows products to the Edge/Chromium WebView on Windows. The products are here: You can see how the WebView is used here. This is a Mac screenshot, but our Windows UI is being updated to look like this: |
Thanks, this is really cool to see! |
We have a working prototype of our product using WebView2. The dev preview was simple to integrate into our code (took less than a day to get a working UI) and seems very stable so far. Still a few things to do, so we'll probably find a few more feature gaps. |
Thanks for creating the
If the final decision is that
Here are a couple of examples of the usefulness of stopping scripts:
Also, why does Will |
Stop was added for folks creating browser like scenarios and so that guides how Stop behaves currently. I'll look into how it interacts with script and get that updated (#50 ). We can look into improvements to Stop related functionality in the future. Stop appears in both interfaces because we want to have the version suffixed interfaces derive from their previous version so we only need to have a pointer to the latest version suffixed interface. IWebView2WebView2 only had Stop on it, so rather than making a breaking change to the interfaces we just added Stop to IWebView2WebView3. We plan to make a breaking change for v1 where we merge all the version suffixed interfaces back down to just one interface. So yes the duplicate Stop is awkward now, but will be addressed in a future breaking change and for sure before we're out of developer preview. |
Windows.UI.Xaml.Controls.WebView has Stop() method
MFC CHtmlView has Stop() method
MsHtml IWebBrowser2 has Stop() method
macOS WkWebView has stopLoading() method
There is a put_Cancel method on IWebView2NavigationStartingEventArgs, but communicating a stop command from the UI to the navigation delegate is a lot more complex than just calling webView->Stop()
Given modern browser UIs merge the Stop and Refresh buttons I'd expect to be able to write something as simple as this:
The text was updated successfully, but these errors were encountered: