Skip to content

Commit

Permalink
msun: remove fabs from Symbol.map, and adjust comment
Browse files Browse the repository at this point in the history
We have s_fabs.c, but fabs(3) is already provided by libc due to
historical reasons, so it is not compiled into libm. When the linker
does not use --undefined-version, this leads to a complaint about the
symbol being nonexistent, so remove it from Symbol.map.

While here, adjust the comment about some functions being supplied by
libc: while it is true that all these are indeed in libc, libm still
includes its own versions of frexp(3), isnan(3), isnanf(3), and
isnanl(3).

Reported by:	Steve Kargl <sgk@troutmask.apl.washington.edu>
MFC after:	3 days

(cherry picked from commit d04e03c19a8d7660ea36f62720eef9bc96b69889)
  • Loading branch information
DimitryAndric authored and laffer1 committed Mar 28, 2024
1 parent e88417a commit ae57157
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 2 additions & 1 deletion lib/msun/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ COMMON_SRCS+= catrig.c catrigf.c \
s_cproj.c s_cprojf.c s_creal.c s_crealf.c s_creall.c \
s_csinh.c s_csinhf.c s_ctanh.c s_ctanhf.c

# BSD's C library supplies these functions:
# BSD's C library supplies these functions (but note we still have s_frexp.c
# and s_isnan.c enabled above, so they are duplicated):
#COMMON_SRCS+= s_fabs.c s_frexp.c s_isnan.c s_ldexp.c s_modf.c

# Exclude the generic versions of what we provide in the MD area.
Expand Down
1 change: 0 additions & 1 deletion lib/msun/Symbol.map
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ FBSD_1.0 {
exp2f;
expm1;
expm1f;
fabs;
fabsf;
fabsl;
fdim;
Expand Down

0 comments on commit ae57157

Please sign in to comment.