Ticket #4427: extfs: "Inconsistent archive" error for valid RPM.

(extfs_read_archive): fix condition to display message "Inconsistent archive". Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
MidnightCommander · Jan 15, 2023 · b2ffac7 · b2ffac7
1 parent 6d7d3e8
commit b2ffac7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/doc/NEWS b/doc/NEWS
@@ -53,7 +53,7 @@ Version 4.8.29
     * FISH subshell: commands don't work after window resize (#4372)
     * FTP VFS: doesn't reconnect to server after timeout (#3670)
     * FISH VFS: cannot remove non-empty directory (#4364)
-    * EXTFS VFS:: segfault if archive contains file(s) in the parent directory (#4422)
+    * EXTFS VFS: segfault if archive contains file(s) in the parent directory (#4422, #4427)
     * Tests: variable redeclaration in filevercmp_test5 (#4358)
 
 

diff --git a/src/vfs/extfs/extfs.c b/src/vfs/extfs/extfs.c
@@ -687,7 +687,7 @@ extfs_read_archive (mc_pipe_t * pip, struct extfs_super_t *archive, GError ** er
 
         g_string_free (err_msg, TRUE);
     }
-    else if (*error == NULL)
+    else if (ret == -1)
         mc_propagate_error (error, 0, "%s", _("Inconsistent archive"));
 
     return ret;