Rubocop fixes

Gemfile

@@ -10,6 +10,6 @@ group :development, :test do
   # compatible with ruby >= 1.9.3
   gem 'guard-rubocop'
   gem 'listen', '3.0.8'
-  gem 'terminal-notifier-guard'
   gem 'openssl', '2.1.2'
+  gem 'terminal-notifier-guard'
 end

lib/crypto.rb

@@ -1,3 +1,3 @@
 module Crypto
-  autoload :PBE, 'crypto/PBE'
+  autoload :PBE, 'crypto/pbe'
 end

lib/crypto/PBE.rb → lib/crypto/pbe.rb

@@ -5,7 +5,7 @@
 module Crypto
   class PBE
     ALPHA_NUM = ('0'..'9').to_a + ('A'..'Z').to_a + ('a'..'z').to_a
-    SPECIALS = ['-', '_', '+', '=', '#', '&', '*', '.']
+    SPECIALS = ['-', '_', '+', '=', '#', '&', '*', '.'].freeze
     CHARS = ALPHA_NUM + SPECIALS
 
     def self.generate
@@ -34,7 +34,7 @@ def derived_key(password, salt, sizeKey = 24)
         salt: salt,
         iterations: @iterations,
         sizeKey: sizeKey,
-        digest: @digest,
+        digest: @digest
       }
       PKCS5.new(args)
     end

spec/crypto/PBE_spec.rb → spec/crypto/pbe_spec.rb

@@ -4,9 +4,9 @@
   let(:specials) { ['-', '_', '+', '=', '#', '&', '*', '.'] }
   let(:valid_chars) { alpha_num + specials }
 
-  describe "#PBE good" do
-    pbe_fixture[:valid].each do | v |
-      describe "#{v.slice(:key, :salt, :keylen, :iterations)}" do
+  describe '#PBE good' do
+    pbe_fixture[:valid].each do |v|
+      describe v.slice(:key, :salt, :keylen, :iterations).to_s do
         let(:pbe) { Crypto::PBE.new(v[:iterations]) }
         let(:key) { pbe.derived_key(v[:key], v[:salt], v[:keylen]) }
         it 'should return a strong key' do
@@ -15,7 +15,7 @@
       end
     end
 
-    describe "Generate random keys" do
+    describe 'Generate random keys' do
       let(:keys) { Set.new }
       5.times do
         key = Crypto::PBE.generate.to_hex
@@ -26,7 +26,7 @@
       end
     end
 
-    describe "Random password + size" do
+    describe 'Random password + size' do
       let(:passwords) { Set.new }
       key_lens = [32, 64, 40]
       5.times do
@@ -39,7 +39,7 @@
         it "should be size #{size}" do
           expect(pass.length).to be size
         end
-        it "should contain specified chars" do
+        it 'should contain specified chars' do
           pass_chars = pass.chars
           expect(pass_chars).to eq(pass_chars & valid_chars)
         end
@@ -48,12 +48,12 @@
   end
 
   describe '#PBE bad' do
-    pbe_fixture[:invalid].each do | v |
-      describe "#{v[:description]}" do
-        let(:pbe){ Crypto::PBE.new(v[:iterations]) }
-        let(:error){ "integer #{v[:keylen]} too big to convert to `int'" }
+    pbe_fixture[:invalid].each do |v|
+      describe v[:description].to_s do
+        let(:pbe) { Crypto::PBE.new(v[:iterations]) }
+        let(:error) { "integer #{v[:keylen]} too big to convert to `int'" }
         it 'should raise key length error' do
-          expect{ pbe.derived_key(v[:key], v[:salt], v[:keylen]) }.to raise_error(RangeError, error)
+          expect { pbe.derived_key(v[:key], v[:salt], v[:keylen]) }.to raise_error(RangeError, error)
         end
       end
     end