Feature/add user setup endpoint #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aromaron
commented
Jan 26, 2018
aromaron
commented
- Add endpoint to request a widget_id for the endorsables setup
- Add specs
- Update readme
- Update version
added 3 commits
January 26, 2018 16:12
- Add endpoint to request a widget_id for the endorsables setup - Add specs - Update readme
1 similar comment
There was a problem hiding this comment.
@aromaron thanks for the pull request, its very complete!
I just have one comment: Please rename the method User.create to User.setup_widget, we have another method to create users (not implemented in this library) and could create conflicts.
|
@aromaron also, please remove the version bump, it has to go to master first. Thanks a lot |
|
Awesome! I just send the changes |
genaromadrid
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.