Threads #66

Mifrill · 2018-10-20T15:32:24Z

No description provided.

…ultiple concurrent threads

houndci-bot · 2018-10-20T15:32:39Z

app/parsers/test_parser.rb

  end

  def second
    puts __method__
-    yield Runner.run(parser: self.class, method: :third, url: nil, data: {})
+    yield task(parser: self.class, method: :third, url: 'http://google.com/', data: {})


Metrics/LineLength: Line is too long. [87/80]

houndci-bot · 2018-10-20T15:32:39Z

app/parsers/test_parser.rb

  end

  def first
    puts __method__
-    yield Runner.run(parser: self.class, method: :second, url: nil, data: {})
+    yield task(parser: self.class, method: :second, url: 'http://google.com/', data: {})


Metrics/LineLength: Line is too long. [88/80]

houndci-bot · 2018-10-20T15:32:39Z

app/app.rb

@@ -40,6 +41,46 @@ def parse_class(text)
    end
  end

+  def start
+    @@runner = Runner.new


Style/ClassVars: Replace class var @@runner with a class instance var.

houndci-bot · 2018-10-20T15:32:40Z

app/app.rb

@@ -40,6 +41,46 @@ def parse_class(text)
    end
  end

+  def start


Metrics/AbcSize: Assignment Branch Condition size for start is too high. [22.2/15]
Metrics/MethodLength: Method has too many lines. [27/10]

Mifrill · 2018-10-20T15:33:27Z

should be test covered

codecov · 2018-10-21T05:43:40Z

Codecov Report

Merging #66 into master will increase coverage by 18.49%.
The diff coverage is 71.64%.

@@             Coverage Diff             @@
##           master      #66       +/-   ##
===========================================
+ Coverage   55.97%   74.46%   +18.49%     
===========================================
  Files           6        4        -2     
  Lines         159       94       -65     
===========================================
- Hits           89       70       -19     
+ Misses         70       24       -46

Impacted Files	Coverage Δ
app/runner.rb	`100% <100%> (ø)`	⬆️
app/task.rb	`100% <100%> (ø)`
app/app.rb	`62.5% <43.47%> (-12.5%)`	⬇️
parsers/test_parser.rb	`53.84% <53.84%> (ø)`
spec/images_by_url_spec.rb

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254f670...298cb30. Read the comment docs.

houndci-bot · 2018-10-21T05:43:54Z

app/task.rb

+    attr_reader :parser, :method, :url, :data
+
+    def initialize(parser:, method:, url:, data:)
+      @parser, @method, @url, @data = parser, method, url, data


Style/ParallelAssignment: Do not use parallel assignment.

houndci-bot · 2018-10-21T05:43:55Z

app/task.rb

@@ -0,0 +1,19 @@
+module Parsers
+  class Task


Style/Documentation: Missing top-level class documentation comment.

houndci-bot · 2018-10-21T05:43:55Z

app/task.rb

@@ -0,0 +1,19 @@
+module Parsers


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-10-21T05:43:55Z

app/app.rb

+    @@runner ||= Runner.new
+  end
+
+  def start


Metrics/MethodLength: Method has too many lines. [12/10]

houndci-bot · 2018-10-21T05:43:55Z

app/app.rb

@@ -40,6 +40,30 @@ def parse_class(text)
    end
  end

+  def runner
+    @@runner ||= Runner.new


Style/ClassVars: Replace class var @@runner with a class instance var.

coveralls · 2018-10-21T05:45:30Z

Coverage increased (+43.3%) to 92.531% when pulling 298cb30 on threads into 254f670 on master.

houndci-bot · 2018-10-21T10:57:06Z

spec/task_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-10-21T10:57:06Z

spec/runner_spec.rb

+    allow(parser).to receive(:test).and_return(something: 'testing')
+  end
+
+  VCR.use_cassette('source') do


Metrics/BlockLength: Block has too many lines. [34/25]

houndci-bot · 2018-10-21T10:57:06Z

spec/runner_spec.rb

@@ -0,0 +1,68 @@
+require 'spec_helper'
+
+describe Parsers::Runner do


Metrics/BlockLength: Block has too many lines. [53/25]

houndci-bot · 2018-10-21T10:57:06Z

spec/runner_spec.rb

@@ -0,0 +1,68 @@
+require 'spec_helper'


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-10-21T10:57:06Z

parsers/test_parser.rb

@@ -0,0 +1,22 @@
+require 'byebug'
+
+class TestParser


Style/Documentation: Missing top-level class documentation comment.

houndci-bot · 2018-10-21T10:57:07Z

parsers/test_parser.rb

@@ -0,0 +1,22 @@
+require 'byebug'


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-10-21T10:57:07Z

app/app.rb

+  private
+
+  def runner
+    @@runner ||= Runner.new


Style/ClassVars: Replace class var @@runner with a class instance var.

houndci-bot · 2018-10-21T12:08:01Z

spec/custom_spec.rb

+
+        array = []
+        find_all('.row').each do |row|
+          array << { "#{row.find('.left').text.to_s}": row.find('.right').text.to_s }


Metrics/LineLength: Line is too long. [85/80]

houndci-bot · 2018-10-21T12:08:01Z

spec/custom_spec.rb

+  end
+end
+
+describe Parsers do


Metrics/BlockLength: Block has too many lines. [43/25]

houndci-bot · 2018-10-21T12:08:01Z

spec/custom_spec.rb

+    it 'does something useful' do
+      VCR.use_cassette('yahoo') do
+        url = 'http://yahoo.com'
+        links = JSON.parse(result.list_links_images(url)).map { |link| link['link'] }


Metrics/LineLength: Line is too long. [85/80]

houndci-bot · 2018-10-21T12:08:02Z

spec/custom_spec.rb

@@ -0,0 +1,77 @@
+require 'spec_helper'


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-10-21T12:08:02Z

spec/app_spec.rb

@@ -1,7 +1,8 @@
-require('spec_helper')
+require 'spec_helper'


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

Mifrill added 3 commits October 20, 2018 19:54

implement threads for runner

843c3cd

use mutex with synchronize to coordinate access to shared data from m…

4d1c72e

…ultiple concurrent threads

fix tests & clenaup

93584f8

Mifrill self-assigned this Oct 20, 2018

houndci-bot reviewed Oct 20, 2018

View reviewed changes

Mifrill added 2 commits October 21, 2018 09:58

add class task with queue

7987c17

infinity loop for threads

a8500be

houndci-bot reviewed Oct 21, 2018

View reviewed changes

Mifrill added 7 commits October 21, 2018 11:25

remove redundant yield; add PP lib; parser init once

f5890ac

resolve infinite loop by queue.empty? checks

1e1c20a

humanize names / cleanup

9d4b1b9

Parsers::Task test covered

3fc520c

test for Parsers#show

6a02515

relocate parsers folder; fix codecov config order

120272c

add runner specs

8bdaefa

houndci-bot reviewed Oct 21, 2018

View reviewed changes

Mifrill added 3 commits October 21, 2018 16:13

clenaup tests(custom_spec); use instance runner var against class var

ea37659

add test for parser#start (TODO)

3b60d1f

fix tests

298cb30

houndci-bot reviewed Oct 21, 2018

View reviewed changes

Mifrill merged commit 8001514 into master Oct 21, 2018

Mifrill deleted the threads branch October 21, 2018 12:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Threads #66

Threads #66

Mifrill commented Oct 20, 2018

houndci-bot Oct 20, 2018

houndci-bot Oct 20, 2018

houndci-bot Oct 20, 2018

houndci-bot Oct 20, 2018

Mifrill commented Oct 20, 2018

codecov bot commented Oct 21, 2018 •

edited

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

coveralls commented Oct 21, 2018 •

edited

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

houndci-bot Oct 21, 2018

		@@ -0,0 +1,68 @@
		require 'spec_helper'

		describe Parsers::Runner do

Threads #66

Threads #66

Conversation

Mifrill commented Oct 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mifrill commented Oct 20, 2018

codecov bot commented Oct 21, 2018 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Oct 21, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 21, 2018 •

edited

coveralls commented Oct 21, 2018 •

edited