fix: quick fix for the GTK accelerators #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MightyCreak
force-pushed
the
fix-menu-accelerators
branch
3 times, most recently
from
89beb32
to
757bce0
Compare
MightyCreak
force-pushed
the
fix-menu-accelerators
branch
from
757bce0
to
0fbc2e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188
It was related to the GTK action names. Only the action names defined in the
menubindings are used withGio.Action.print_detailed_namewhich doesn't tolerate_in the action name. This is a quick fix (of a quick fix 😅 ) and this time it properly formats the action name as GTK would expect it.