Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appdata and translation related patches #219

Closed
wants to merge 0 commits into from
Closed

Appdata and translation related patches #219

wants to merge 0 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 6, 2024

appdata: Update appdata

  • Add vcs-browser and translate URLs
  • Add the translation tag
  • Mark the developer name and release descriptions as untranslatable
  • Use appstreamcli to validate appdata
  • Activate test on build process
  • Remove redundant paragraph from the translation document

po: Update Turkish translation

@MightyCreak
Copy link
Owner

I'll take a look at that!

I didn't know about the translatable="no", that's going to simplify the translation process, thank you!

@ghost
Copy link
Author

ghost commented Jan 6, 2024

I'll take a look at that!

I didn't know about the translatable="no", that's going to simplify the translation process, thank you!

It's useful, and I've applied it to all my translated projects. Additionally, there's an appdata validation error that causes build failure. I believe we can switch to appstreamcli, which seems to be more in line with my GNOME initiative

data/io.github.mightycreak.Diffuse.appdata.xml.in Outdated Show resolved Hide resolved
data/io.github.mightycreak.Diffuse.appdata.xml.in Outdated Show resolved Hide resolved
po/POTFILES Outdated Show resolved Hide resolved
@MightyCreak
Copy link
Owner

I'll take a look at that!
I didn't know about the translatable="no", that's going to simplify the translation process, thank you!

It's useful, and I've applied it to all my translated projects. Additionally, there's an appdata validation error that causes build failure. I believe we can switch to appstreamcli, which seems to be more in line with my GNOME initiative

I'll take a look at that too, thanks!

@MightyCreak
Copy link
Owner

I'll take a look at that!
I didn't know about the translatable="no", that's going to simplify the translation process, thank you!

It's useful, and I've applied it to all my translated projects. Additionally, there's an appdata validation error that causes build failure. I believe we can switch to appstreamcli, which seems to be more in line with my GNOME initiative

I'll take a look at that too, thanks!

In your initiative, you talk about using <developer id="gnome.org"> instead of <developer_name/> , I'm good with that, especially since <developer_name/> is apparently deprecated, but I don't know what should I put in the id attribute. Is my email a good id? or should it be the diffuse website?

@ghost
Copy link
Author

ghost commented Jan 6, 2024

The developer id part is not yet functional in Flathub or GNOME Software.

I have an open question/issue regarding this topic to the appdata developers.

@MightyCreak
Copy link
Owner

@sabriunal It seems that you rebased on the wrong branch (diff is +15,124 −13,543 😅 )

@ghost ghost closed this Jan 6, 2024
@ghost
Copy link
Author

ghost commented Jan 6, 2024

something went wrong and I lost your patches

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant