Plugin hooks and settings fixes #140
Conversation
| } | ||
| } | ||
|
|
||
| // if the plugin has a class (events, etc), register it. | ||
| $plugin_class_name = 'plugin_' . $k; | ||
| if (class_exists($plugin_class_name)) | ||
| $plugin_class_name = 'class_plugin_' . $k; |
There was a problem hiding this comment.
Why did you change the name of the class? I can't remember why I have used that name, but maybe some private plugins are using the other format... I need to check before integrating your code.
There was a problem hiding this comment.
After having looked at the code and analyzed other plugins, I still prefer to keep the inclusion of the autoload class in a simpler way, so every plugin may have a file called "class.php" within his root folder which gets included automatically. I will accept the name change of the class, but unless there is another good reason, I won't add another INCLUDE to common.php (it just complicate the code, without adding anything really beneficial, at least at a first look).
There was a problem hiding this comment.
class.php doesn't get loaded automatically, does it?
| @@ -71,11 +71,11 @@ function create_input($name, $properties) | |||
| break; | |||
|
|
|||
| case 'LIST_CHECKBOX': | |||
| case 'LIST_FLAGS': | |||
There was a problem hiding this comment.
Because in the case of a LIST_FLAGS, we don't want an array of default values.
| @@ -26,7 +26,7 @@ class class_plugins | |||
| var $plugins_path = ''; | |||
| var $plugins_settings_path = ''; | |||
|
|
|||
| var $plugin_includes_array = array('constants', 'common', 'functions', 'class'); | |||
There was a problem hiding this comment.
I prefer keeping 'class' here. We will discuss privately the reason
There was a problem hiding this comment.
If I remember correctly, 'class' was an addition I made that broke things.
| global $config; | ||
|
|
||
| $files = array(); | ||
| $base_dir = '../../' . PLUGINS_PATH; |
There was a problem hiding this comment.
Why you didn't use IP_ROOT_PATH instead of '../../'?
There was a problem hiding this comment.
Because the template class doesn't know how to handle IP_ROOT_PATH. I tried it.
No description provided.