Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added term windows and multiscreen support to OpenOS. (no multithread…
…ing though) Also added wide character support to edit.lua
- Loading branch information
Showing
12 changed files
with
877 additions
and
370 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
29c49e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in term.lua, the __gc of the metatable is assigned twice
29c49e0#diff-a97cafc4e4a993f5f6cf8eba5cedf0ffR22
Is that correct?
29c49e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops... (I'll fix that in the next days.)
Btw.: You asked me to test parts of your changes to OpenOS? Where can I find them?
29c49e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sangar is reviewing my PR -- can we do one of two things
Sangar is reviewing my enormous PR, and I'm working on reducing memory cost to openos boot
I should have 2 PRs for openos 1.6, the first is the bulk of the work, the 2nd will mainly be memory optimizations (with a few minor bug fixes I find along the way)
PR1: openos overhaul, bash like shell and more bin utils #1610
You can test that to verify your terminal code
29c49e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in the process of getting rid of
__gc
s right now (see #1606). For file handles I'm adding a userdata handle wrapper, for this... I'll just remove it. Yes, things may derp around when a window is 'lost', but that's not a big issue compared to real resources (as is potentially the case with file handles).29c49e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workaround isn't that hard. Stopping the cursor blink can be moved to the toggleblink and the neighbour lists need some additional data to detect "gaps".