refactored line and char position to be in a pos object
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCastillo
added a commit
that referenced
this pull request
Apr 2, 2015
refactored line and char position to be in a `pos` object
| @@ -65,13 +65,15 @@ define(function (require /*, exports, module*/) { | |||
| $problemsPanelTable = $problemsPanel.find(".table-container"); | |||
| $problemsPanelTable.on("click", "tr", function () { | |||
| var $target = $(this); | |||
| var line = $target.data("line") - 1; // Convert from friendly line to actual line number | |||
|
|
|||
| var line = $target.data("line"); // Convert from friendly line to actual line number | |||
There was a problem hiding this comment.
I think that removing the comment from this line seems like a good idea (or restoring the - 1 after the query, if it is needed).
There was a problem hiding this comment.
I now see the subtraction on lines 73 and 74; perhaps moving this comment to there would be the better option.
There was a problem hiding this comment.
You are right. That comment does not apply anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.