remove dynamic plugins #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 10, 2017 22:54
… specific environment setup
…assing a function would cause the plugin to use the name of the function as the plugin name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes dynamic loading of plugin handlers. This is primarily to just simplify the code base and the workflow for working with bit-loader. The preferred approach is to passed in plugins with all handler functions eagerly configured. This means that bit-imports is affected in that it will no longer be able to dynamically load plugin handlers. The approach moving forward will be to bundle bit-imports configuration to eagerly load plugins and package the whole thing together as a runtime.