Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification of the original view position #100

Closed
dentvii opened this issue May 21, 2024 · 1 comment
Closed

Modification of the original view position #100

dentvii opened this issue May 21, 2024 · 1 comment
Assignees
Labels
priority: now type: bug Something isn't working

Comments

@dentvii
Copy link

dentvii commented May 21, 2024

ScreenRecording2024-05-21at15 17 24-ezgif com-video-to-gif-converter

Issue Description

When implementing a pop-up, the view in which it is hosted is altered. The view should only be as big as its container, but when the pop-up is implemented, it shifts to the top leading position, modifying the view itself.

Steps to Reproduce

  1. Create a small view:
    • Create a view that is relatively small.
  2. Implement the pop-up:
    • Add the pop-up to the small view.

Observed Behavior

  • If the view is small, the pop-up is positioned at the top leading.
  • If the view is not small, the pop-up is centered.
  • This change does not affect the behavior of the pop-up but modifies the position of the view.

Suggested Solution

Wrap the view in a container to protect its location and size, especially if the view is small. This might be an edge case, as most developers will implement a full view to start their application, but it's worth noting that the original view is modified.

@FulcrumOne
Copy link
Contributor

Good finding @dentvii, thanks! Patch-2.4.2 branch solves this problem too

@FulcrumOne FulcrumOne self-assigned this May 24, 2024
@FulcrumOne FulcrumOne added type: bug Something isn't working priority: now labels May 24, 2024
@FulcrumOne FulcrumOne mentioned this issue May 30, 2024
FulcrumOne added a commit that referenced this issue May 30, 2024
fix:
- Fixed a problem with the safe area for BottomPopup (#97)
- Fixed a problem where the library was modifying the source view (#100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: now type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants