Do not allow duplicate ipv4hint and ipv6hint parameters #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contents already encode multiple addresses. We shouldn't have multiple ways to say the same thing.
|
@dmcardle FYI |
|
I think if we address issue #95 and just recommend using a multi-value parameter (and have very clear specification that duplicate parameters must ignored in a deterministic manner) that this text isn't needed as-is. |
|
Should we replace this with text elsewhere prohibiting the same parameter key from being used multiple times and specifying that one (first? last?) should be deterministically selected? |
enygren
added a commit
that referenced
this pull request
Mar 5, 2020
* Only allow each SvcParamKey to appear once This includes some adjustments to make repeated keys unnecessary. Incorporates #94 by @davidben Addresses #95 * Reject the entire RRSet * Reject the whole RRSet if any RR is malformed Also clarify recursive resolver requirements. * Incorporate review comments
|
This has been merged in #109. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contents already encode multiple addresses. We shouldn't have multiple ways to say the same thing.