Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

Franz Dark - installation - can't add services #1

Closed
alapo opened this issue Nov 2, 2018 · 11 comments
Closed

Franz Dark - installation - can't add services #1

alapo opened this issue Nov 2, 2018 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@alapo
Copy link

alapo commented Nov 2, 2018

Sorry I could not open an issue in the Franz Dark Project. I wanted to message you privately but could not find an email. I downloaded your compiled Dark Version of Franz and it might be on my end but I found some bugs. Below are detailed notes. Happy to post it on the issue 49 PR post but seemed more appropriate to private message.

If fixed I would be happy to make another video like this showing detailed installation steps which might make your version more popular among less code oriented users such as myself.

Franz Dark

@MikeDabrowski
Copy link
Owner

Sorry, I unblocked issues.
I recognize the problem you are facing though I forgot what caused it. Could you send me screenshot of dev console when you have problems adding service just like at 0:20 in your video?

Are you aiming to get exactly the look at my preview there ? I'm very happy you want to try it so I will prep nice interface to set background and detailed 'how to' for setting it up. I added my email in bio.

@MikeDabrowski MikeDabrowski transferred this issue from another repository Nov 2, 2018
@MikeDabrowski
Copy link
Owner

@alapo
I updated 5.0.0-beta.19 release here https://github.com/MikeDabrowski/franz/releases/tag/v5.0.0-beta.19
It has the same number because I cleaned up repository, and made nice commits and even updated changelog, so I wanted to keep numbering in order.
Also please make sure to get me that console screenshot of when you can't add service.

@MikeDabrowski MikeDabrowski self-assigned this Nov 2, 2018
@MikeDabrowski MikeDabrowski added the bug Something isn't working label Nov 2, 2018
@MikeDabrowski MikeDabrowski changed the title Franz Dark Franz Dark - installation - can't add services Nov 2, 2018
@alapo
Copy link
Author

alapo commented Nov 2, 2018

@alapo
I updated 5.0.0-beta.19 release here https://github.com/MikeDabrowski/franz/releases/tag/v5.0.0-beta.19
It has the same number because I cleaned up repository, and made nice commits and even updated changelog, so I wanted to keep numbering in order.
Also please make sure to get me that console screenshot of when you can't add service.

Hey Mike I sent it to you in an email but here is a copy. I will try the new version right now

Hi Mike,

Thanks for the quick response. As you requested the dev console screenshots are below. I also uploaded a new video that has more details.
Franz Dark

Let me know if you prefer to communicate via email or if you would like me to post it under "Issues" under your fork on GitHub.

Although I am not code-oriented enough to help with some aspects I would be more than happy to provide a guide and help in any other way you deem fit (e.g. Documentation/Guides)

DevConsole - Before Importing Recipes
https://i.imgur.com/iusgOby.png

DevConsole - After Importing Missing Recipes
https://i.imgur.com/Q47MFP8.png

@alapo
Copy link
Author

alapo commented Nov 3, 2018

The newest release fixes the issue with adding services and also fixes the weirdness that was occurring with Gmail. Messenger still does not appear to function with dark theme. As usual, below is a video in case it helps. Could this be related to Application Background image?

Franz Dark 3

I should also mention that at the moment the Transparent theme is only working on the sidebar and Menu bar. It does not seem to function on the main body of the app (at least for services I use which are Messenger, Gmail, Steam, WhatsApp, Hangouts, GitHub and Skype). I believe that Gmail is only showing a black background because I selected it from the drop-down menu in Gmail themes

Image of Transparent mode
https://i.imgur.com/Vo42u5v.png
Transparent Mode

@alapo alapo closed this as completed Nov 3, 2018
@alapo alapo reopened this Nov 3, 2018
@MikeDabrowski
Copy link
Owner

The theme you can select in Franz setting apply only to Franz itself that is sidebar topbar and settings menu. All other PRs are similar.

If you want to have every service dark you have to look for dark services, there are a couple somewhere on GitHub.

Application background works only with transparent theme because of obvious reason - you need to see through. In my other repo with transparent services there is instruction how to add them. Have you tried that already? Perhaps I should enable that setting only when transparent mode is selected...

Thank you for your time and I videos and not giving up :)

@alapo
Copy link
Author

alapo commented Nov 3, 2018

Thanks for your help. I will get to work on some videos this weekend. I will also show how to add your own CSS (it got asked a bunch in the forums). I have one final question if you would not mind entertaining it. I am not fully versed in CSS but I was curious why stylesheets with variable declarations such as this one won't work when added as a CSS.

CSS sheet

@MikeDabrowski
Copy link
Owner

I think it might be platform specific. What you attached above is perhaps taken from userstyles.org. Stylus or original app might have parsed that ok, but in general css doesn't have this syntax. /* */ is just a comment so it is omitted.
If you are working on theming other apps you use I'd be happy to see PR with your changes. I'm just finishing #2 so you can start from there ;)

@alapo
Copy link
Author

alapo commented Nov 3, 2018

Sounds good I figured out the issues with CSS styles. It was not based on the /* */ comments. I will make a post in the coming weeks to show others how to do it if they would like to. I just got it mostly working for WhatsApp.

@MikeDabrowski
Copy link
Owner

Sure, take look at my themed recipes, I updated readme. You can add your versions for other apps.
I'm currently fighting with slack - doesn't load themes ...

@MikeDabrowski
Copy link
Owner

MikeDabrowski commented Mar 6, 2019

@alapo can we close this issue now ?

@MikeDabrowski
Copy link
Owner

Closing due to no reaction

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants