Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google OAuth 2.0 Update #56

Closed
motoxcrazy opened this issue Mar 21, 2022 · 5 comments
Closed

Google OAuth 2.0 Update #56

motoxcrazy opened this issue Mar 21, 2022 · 5 comments
Assignees
Labels
bug Something isn't working done Feature has been implemented, tested and released

Comments

@motoxcrazy
Copy link
Contributor

motoxcrazy commented Mar 21, 2022

As of Feb 28, 2022, the redirect_uri: "urn:ietf:wg:oauth:2.0:oob" has been deprecated.
This prevents users from being able to complete the Authorization process to link their Google Photos to the ePiframe

At present I have been unable to find a solution with my very limited Ruby & python knowledge.
image

@MikeGawi MikeGawi self-assigned this Mar 21, 2022
@MikeGawi MikeGawi added the research Solution searching label Mar 21, 2022
@MikeGawi
Copy link
Owner

Thanks for the information, I was afraid it's going to happen. I will look for the solution and implement the fix as soon as possible.

@MikeGawi MikeGawi added in progress Request is being implemented and removed research Solution searching labels Mar 23, 2022
@MikeGawi
Copy link
Owner

Research done and I will go with the hints from here:
https://stackoverflow.com/questions/71318804/google-oauth-2-0-failing-with-error-400-invalid-request-for-some-client-id-but

Proof of concept done and working, so started implementation.

@MikeGawi MikeGawi added testing Feature has been implemented but it's in testing phase and removed in progress Request is being implemented labels Mar 25, 2022
MikeGawi added a commit that referenced this issue Mar 26, 2022
@MikeGawi MikeGawi added done Feature has been implemented, tested and released and removed testing Feature has been implemented but it's in testing phase labels Mar 26, 2022
@MikeGawi
Copy link
Owner

MikeGawi commented Mar 26, 2022

Done and pushed. Please check it and let me know if it works.

Unfortunately "copy URL" method was the only method possible as activation script should be work from other IP than localhost only and non-localhost, internal IPs are not supported by Google :(

@MikeGawi MikeGawi added the bug Something isn't working label Mar 26, 2022
@motoxcrazy
Copy link
Contributor Author

Apologies if not same issue - getting this error when running --test:
ImportError: cannot import name 'safe_str_cmp' from 'werkzeug.security' (/usr/local/lib/python3.9/dist-packages/werkzeug/security.py)

Have I missed something? Or could this be to do with OAuth again?

@MikeGawi
Copy link
Owner

Probably not related with OAuth: Werkzeug released v2.1.0 today, removing werkzeug.security.safe_str_cmp.

Moving to #58, but thank you for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done Feature has been implemented, tested and released
Projects
None yet
Development

No branches or pull requests

2 participants