REFACTOR: Rename aliases to monikers

- Updating the name from aliases to monikers as getAlias in the prior version has a few specific meanings

src/conversion/azure/azure_converter.ts

@@ -53,7 +53,7 @@ export class AzureConverter {
 
       itemsToMap.push(item);
 
-      for (const index of converter.aliases(item)) {
+      for (const index of converter.monikers(item)) {
         if (index.item) {
           this.entityStore.registerEntity(index.item, index.alias);
         }

src/conversion/azure/base_azure_converter.ts

@@ -1,4 +1,4 @@
-import {AnyAzureObject, IAzureConverter, ItemAlias} from '.';
+import {AnyAzureObject, IAzureConverter, ItemMoniker} from '.';
 import {IEntityStore, IRules} from '..';
 import {NodeSpec} from '../..';
 
@@ -9,7 +9,7 @@ export abstract class BaseAzureConverter implements IAzureConverter {
     this.supportedType = supportedType;
   }
 
-  aliases(item: AnyAzureObject): ItemAlias[] {
+  monikers(item: AnyAzureObject): ItemMoniker[] {
     return [{item, alias: item.name}];
   }
 

src/conversion/azure/contracts.ts

@@ -2,14 +2,14 @@ import {AnyAzureObject} from '.';
 import {IEntityStore, IRules} from '..';
 import {NodeSpec} from '../..';
 
-export interface ItemAlias {
+export interface ItemMoniker {
   readonly item: AnyAzureObject | undefined;
   readonly alias: string;
 }
 
 export interface IAzureConverter {
   readonly supportedType: string;
-  aliases(input: AnyAzureObject): ItemAlias[];
+  monikers(input: AnyAzureObject): ItemMoniker[];
   convert(
     input: AnyAzureObject,
     stores: IEntityStore<AnyAzureObject>

src/conversion/azure/converter_store.ts

@@ -2,7 +2,7 @@ import {
   BaseAzureConverter,
   IAzureConverter,
   AnyAzureObject,
-  ItemAlias,
+  ItemMoniker,
 } from '.';
 
 export class ConverterStore {
@@ -32,12 +32,12 @@ class DefaultConverter extends BaseAzureConverter {
     super('DefaultTypes*');
   }
 
-  aliases(input: AnyAzureObject): ItemAlias[] {
-    const aliases: ItemAlias[] = [];
-    aliases.push({
+  monikers(input: AnyAzureObject): ItemMoniker[] {
+    const monikers: ItemMoniker[] = [];
+    monikers.push({
       item: input,
       alias: '',
     });
-    return aliases;
+    return monikers;
   }
 }

src/conversion/azure/network_interface_converter.ts

@@ -5,7 +5,7 @@ import {
   ConverterStore,
   AzureNetworkInterface,
   BaseAzureConverter,
-  ItemAlias,
+  ItemMoniker,
   LocalIpConverter,
   PublicIpConverter,
 } from '.';
@@ -21,24 +21,24 @@ export class NetworkInterfaceConverter extends BaseAzureConverter {
     );
   }
 
-  aliases(input: AnyAzureObject): ItemAlias[] {
-    const aliases = super.aliases(input);
+  monikers(input: AnyAzureObject): ItemMoniker[] {
+    const monikers = super.monikers(input);
     const nic = input as AzureNetworkInterface;
 
     for (const config of nic.properties.ipConfigurations) {
       const converter = this.ipConverters.asConverter(config);
 
       if (converter) {
-        for (const alias of converter.aliases(config)) {
-          aliases.push({
+        for (const alias of converter.monikers(config)) {
+          monikers.push({
             item: alias.item,
             alias: `${nic.name}/${alias.alias}`,
           });
         }
       }
     }
 
-    return aliases;
+    return monikers;
   }
 
   convert(

src/conversion/azure/subnet_converter.ts

@@ -11,7 +11,7 @@ import {
   PublicIpConverter,
 } from '.';
 import {AzureNetworkSecurityGroup, AzureVirtualNetwork} from './schema';
-import {IEntityStore, ItemAlias} from '..';
+import {IEntityStore, ItemMoniker} from '..';
 
 export class SubnetConverter extends BaseAzureConverter {
   private readonly converters: ConverterStore;
@@ -30,13 +30,13 @@ export class SubnetConverter extends BaseAzureConverter {
     return path.dirname(path.dirname(id));
   }
 
-  aliases(input: AnyAzureObject): ItemAlias[] {
-    const aliases: ItemAlias[] = [];
-    aliases.push({
+  monikers(input: AnyAzureObject): ItemMoniker[] {
+    const monikers: ItemMoniker[] = [];
+    monikers.push({
       item: input,
       alias: `${input.name}/router`,
     });
-    return aliases;
+    return monikers;
   }
 
   convert(

src/conversion/azure/virtual_network_converter.ts

@@ -7,7 +7,7 @@ import {
   parseIp,
 } from '../..';
 import {ForwardRuleSpecEx, NodeSpec, SymbolStore} from '../../graph';
-import {IAzureConverter, ItemAlias} from './contracts';
+import {IAzureConverter, ItemMoniker} from './contracts';
 import {AnyAzureObject, AzureVirtualNetwork} from './schema';
 import {BaseAzureConverter} from './base_azure_converter';
 import {SubnetConverter} from './subnet_converter';
@@ -27,17 +27,17 @@ export class VirtualNetworkConverter extends BaseAzureConverter {
     this.vnets = new Map<string, string>();
   }
 
-  aliases(input: AnyAzureObject): ItemAlias[] {
-    const aliases = super.aliases(input);
+  monikers(input: AnyAzureObject): ItemMoniker[] {
+    const monikers = super.monikers(input);
     const vnet = input as AzureVirtualNetwork;
 
     for (const subnet of vnet.properties.subnets) {
-      for (const alias of this.subnetConveter.aliases(subnet)) {
-        aliases.push(alias);
+      for (const alias of this.subnetConveter.monikers(subnet)) {
+        monikers.push(alias);
       }
     }
 
-    return aliases;
+    return monikers;
   }
 
   convert(

test/conversion/convert_azure.test.ts

@@ -43,10 +43,10 @@ describe('Conversion - Convert Azure', () => {
       type: 'microsoft.network/networkinterfaces',
     } as AzureNetworkInterface;
 
-    it('Aliases for NIC with single ip', () => {
-      const aliases = nicConverter.aliases(input);
-      assert.equal(aliases[0].alias, 'testingcreds68');
-      assert.equal(aliases[1].alias, 'testingcreds68/ipconfig1');
+    it('Monikers for NIC with single ip', () => {
+      const monikers = nicConverter.monikers(input);
+      assert.equal(monikers[0].alias, 'testingcreds68');
+      assert.equal(monikers[1].alias, 'testingcreds68/ipconfig1');
     });
 
     it('Conversion of NIC with single', () => {
@@ -62,7 +62,7 @@ describe('Conversion - Convert Azure', () => {
         },
       ];
 
-      for (const data of nicConverter.aliases(input)) {
+      for (const data of nicConverter.monikers(input)) {
         if (data.item) {
           store.registerEntity(data.item, data.alias);
         }
@@ -145,15 +145,15 @@ describe('Conversion - Convert Azure', () => {
       assert.equal(result, expected);
     });
 
-    it('Subnet aliases should be consistent', () => {
+    it('Subnet monikers should be consistent', () => {
       const expected = [
         {
           item: inputSubnet,
           alias: 'A/router',
         },
       ];
 
-      const result = converter.aliases(inputSubnet);
+      const result = converter.monikers(inputSubnet);
       assert.deepEqual(result, expected);
     });
   });