fix(eval): uses instead of strict boolean matching

MikeIbberson · Apr 16, 2020 · f30bfac · f30bfac
1 parent 0ade589
commit f30bfac
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/__tests__/comparison.test.js b/lib/__tests__/comparison.test.js
@@ -10,11 +10,13 @@ const exp = [
   'colleague.age=*',
   '!colour',
   'new=true',
+  'old=false',
 ];
 
 const stub = {
   new: true,
   colour: null,
+  old: false,
   foo: 'bar',
   age: 21,
   language: 'en',
@@ -61,6 +63,7 @@ describe('Comparison', () => {
           { 'colleague.age': { $exists: true } },
           { 'colour': { $eq: null } },
           { 'new': true },
+          { 'old': { $ne: true } },
         ],
       }));
 

diff --git a/lib/utils.js b/lib/utils.js
@@ -1,6 +1,7 @@
 const moment = require('moment');
 
 const toBoolean = (v) => v === 'true';
+const toMongoBoolean = (exists) => (exists ? true : { $ne: true });
 
 const validate = (v) => ({
   alpha: () => new RegExp(/^[A-Z]+$/, 'gi').test(v),
@@ -104,7 +105,7 @@ const cast = (v) => {
   const test = validate(v);
   if (test.date()) return v;
   if (test.numeric()) return parseFloat(v);
-  if (test.boolean()) return toBoolean(v);
+  if (test.boolean()) return toMongoBoolean(toBoolean(v));
   return new RegExp(v, 'i');
 };