Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add module and jsnext:main field to package.json #94

Merged
merged 2 commits into from
May 19, 2018

Conversation

jaeh
Copy link
Contributor

@jaeh jaeh commented May 18, 2018

i am using the library in an mjs codebase built with rollup and without one of those fields (depending on the rollup-plugin-resolve config, thats why i added both) the config might break. this means without the fields one would need to

import Big from 'big.js/big.mjs'

because the mjs module can not be resolved.

@MikeMcl
Copy link
Owner

MikeMcl commented May 18, 2018

Okay, just the module field please.

The property jsnext:main is now deprecated. It was superseded by module.

remove jsnext:main
@MikeMcl MikeMcl merged commit 12a9eac into MikeMcl:master May 19, 2018
@MikeMcl
Copy link
Owner

MikeMcl commented May 19, 2018

Thank you.

@MikeMcl
Copy link
Owner

MikeMcl commented May 19, 2018

Although, I just did the same to bignumber.js and it seems to have caused problems. Any comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants