Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert range component output to unordered list and add ages #14

Closed
MikePiper opened this issue May 15, 2020 · 4 comments
Closed

Convert range component output to unordered list and add ages #14

MikePiper opened this issue May 15, 2020 · 4 comments

Comments

@MikePiper
Copy link
Owner

MikePiper commented May 15, 2020

relates to branch: component-for-range-of-options

Maybe the "claim dates" part of the output would be a little more clear as an unordered list.

Also, I know from feedback I received on the original release of the calculator that people will want to see the age as well as the date.

Maybe something like this:


Selected option:

  • date1 (with age included)
  • date2 (with age included)
  • date3 (with age included)
  • PV
  • PV as percent of max

@brian-courts
Copy link
Contributor

brian-courts commented May 15, 2020

Regarding the problems of which claim dates are reported, and how:

My system is very crude. I think what is needed is a variation of what you do when you show claim dates and ages for an alternative strategy - take the proposed dates and see which ones actually work, and derive the sentences you put in the output (or a table, as you propose above).

In fact, it might make sense to create that entire alternative strategy output, including the table of year-by-year benefits, when a person selects a date. I would put that in a separate <div> below the graph, rather than beside it (where my output is).

You're much more adept and familiar with those calcs, so if you'd like to take on that revision, I'd be delighted.

If you want me to try, I'll give it a shot.

@MikePiper
Copy link
Owner Author

I can take this one on. Might not get to start working on it though until Monday or Tuesday. And I don't really have any sense of how hard it's going to be. We'll see!

@brian-courts
Copy link
Contributor

brian-courts commented May 16, 2020 via email

@MikePiper
Copy link
Owner Author

MikePiper commented May 19, 2020

I just made a new commit that uses the functions in solutionset.service to create strings related to the selected filling date(s), which are then used to populate an unordered list.

Would you mind giving it a test to see what you think? (I'll leave this "issue" open so that continued discussion can occur in case you have other suggestions/concerns/comments.)

I think this means we can also delete the various code relating to selectedClaimDatesString and selectedPercentString, but I wanted to check with you before doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants