Fix tidy unit tests after visitor changes

MikePopoloski · Jun 30, 2023 · 37a3765 · 37a3765
1 parent f356032
commit 37a3765
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/include/slang/ast/ASTVisitor.h b/include/slang/ast/ASTVisitor.h
@@ -107,6 +107,10 @@ class ASTVisitor {
 
 /// @brief Creates an ASTVisitor out of the provided handler functions.
 ///
+/// The provided callable arguments must take two parameters, the first of which
+/// is the visitor object itself (so that you can call visitDefault on it if
+/// desired) and the second is the AST type to match against.
+///
 /// For example, to create a visitor that will count all of the BinaryExpressions
 /// in an AST:
 ///

diff --git a/tools/tidy/src/style/AlwaysCombNonBlocking.cpp b/tools/tidy/src/style/AlwaysCombNonBlocking.cpp
@@ -19,7 +19,7 @@ struct MainVisitor : public TidyVisitor, ASTVisitor<MainVisitor, true, false> {
         NEEDS_SKIP_SYMBOL(symbol)
         if (symbol.procedureKind == ProceduralBlockKind::AlwaysComb) {
             bool hasNonBlockingAssignment = false;
-            symbol.visitStmts(makeVisitor([&](const AssignmentExpression& expr) {
+            symbol.visitStmts(makeVisitor([&](auto&, const AssignmentExpression& expr) {
                 if (expr.isNonBlocking()) {
                     hasNonBlockingAssignment = true;
                 }

diff --git a/tools/tidy/src/style/AlwaysFFBlocking.cpp b/tools/tidy/src/style/AlwaysFFBlocking.cpp
@@ -20,11 +20,12 @@ struct MainVisitor : public TidyVisitor, ASTVisitor<MainVisitor, true, false> {
         if (symbol.procedureKind == ProceduralBlockKind::AlwaysFF) {
             // Collect all declared local variables
             std::vector<std::string_view> locals;
-            symbol.visitStmts(makeVisitor(
-                [&](const VariableDeclStatement& decl) { locals.push_back(decl.symbol.name); }));
+            symbol.visitStmts(makeVisitor([&](auto&, const VariableDeclStatement& decl) {
+                locals.push_back(decl.symbol.name);
+            }));
 
             bool hasBlockingAssignments = false;
-            symbol.visitStmts(makeVisitor([&](const AssignmentExpression& expr) {
+            symbol.visitStmts(makeVisitor([&](auto&, const AssignmentExpression& expr) {
                 if (expr.isBlocking()) {
                     auto identifier = getIdentifier(expr.left());
                     if (identifier && std::find(locals.begin(), locals.end(), identifier.value()) ==