Fix parameter default value visitor

MikePopoloski · May 26, 2024 · cabaf18 · cabaf18
1 parent cad94bc
commit cabaf18
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/source/ast/symbols/ParameterSymbols.cpp b/source/ast/symbols/ParameterSymbols.cpp
@@ -64,14 +64,14 @@ void ParameterSymbolBase::checkDefaultExpression() const {
 
             for (auto& selector : result.selectors) {
                 if (auto elemSel = std::get_if<0>(&selector))
-                    visitDefault(**elemSel);
+                    (*elemSel)->visit(*this);
             }
         }
 
         void handle(const AssignmentPatternItemSyntax& syntax) {
             // Avoid visiting the key which can name a struct member
             // and so should not be looked up.
-            visitDefault(*syntax.expr);
+            syntax.expr->visit(*this);
         }
 
         const ASTContext& context;

diff --git a/tests/unittests/ast/ParameterTests.cpp b/tests/unittests/ast/ParameterTests.cpp
@@ -1181,3 +1181,33 @@ endmodule
     compilation.addSyntaxTree(tree);
     NO_COMPILATION_ERRORS;
 }
+
+TEST_CASE("Parameter default checking error regress -- GH #1009") {
+    auto tree = SyntaxTree::fromText(R"(
+package my_pkg;
+
+typedef enum logic {
+	CaseA
+} unit_t;
+
+typedef struct {
+	unit_t val;
+} struct_t;
+
+endpackage
+
+module param_top #(
+	parameter my_pkg::struct_t Param = '{default: my_pkg::CaseA}
+);
+endmodule
+
+module top;
+param_top f(); // elaborates fine
+param_top #(.Param('{my_pkg::CaseA})) g();
+endmodule
+)");
+
+    Compilation compilation;
+    compilation.addSyntaxTree(tree);
+    NO_COMPILATION_ERRORS;
+}