Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hierarchical paths inside generate arrays #1031

Merged
merged 3 commits into from
Jun 16, 2024

Conversation

povik
Copy link
Contributor

@povik povik commented Jun 15, 2024

Take some input with an unnamed generate array, e.g.

module top;
  genvar i;
  for (i = 0; i < 1; i = i + 1) begin
    logic a;
  end
endmodule

make a fix so that the hierpath of the wire is top.genblk1[0].a not
top[0].a.

Take some input with an unnamed generate array, e.g.

  module top;
    genvar i;
    for (i = 0; i < 1; i = i + 1) begin
      logic a;
    end
  endmodule

make a fix so that the hierpath of the wire is `top.genblk1[0].a` not
 `top[0].a`.
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.70%. Comparing base (8637e2e) to head (f43ddd5).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1031   +/-   ##
=======================================
  Coverage   94.70%   94.70%           
=======================================
  Files         191      191           
  Lines       47569    47597   +28     
=======================================
+ Hits        45048    45078   +30     
+ Misses       2521     2519    -2     
Files Coverage Δ
source/ast/Symbol.cpp 96.10% <100.00%> (+0.10%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8637e2e...f43ddd5. Read the comment docs.

@MikePopoloski
Copy link
Owner

Thanks for the PR. Can you add a test that covers this logic so that it doesn't break in the future?

@povik
Copy link
Contributor Author

povik commented Jun 15, 2024

@MikePopoloski take a look

@MikePopoloski MikePopoloski merged commit 61fc44c into MikePopoloski:master Jun 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants