Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[slang] Introduce net aliases bits duplication checks #1045

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

likeamahoney
Copy link
Contributor

Introduce 2 new net alias bit checks from SystemVerilog LRM section 10.11:

  • check that net aliased to itself
  • check that aliased bits specified more than once at module instance scope

@likeamahoney
Copy link
Contributor Author

I think with it LRM section 10.11 is done

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 86.30137% with 10 lines in your changes missing coverage. Please review.

Project coverage is 94.68%. Comparing base (4dee9aa) to head (16b72d5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
- Coverage   94.71%   94.68%   -0.03%     
==========================================
  Files         191      191              
  Lines       47664    47726      +62     
==========================================
+ Hits        45144    45190      +46     
- Misses       2520     2536      +16     
Files Coverage Δ
include/slang/ast/Compilation.h 100.00% <100.00%> (ø)
include/slang/ast/Scope.h 100.00% <ø> (ø)
include/slang/ast/symbols/InstanceSymbols.h 100.00% <100.00%> (ø)
source/ast/symbols/InstanceSymbols.cpp 94.51% <100.00%> (+<0.01%) ⬆️
source/ast/symbols/MemberSymbols.cpp 96.86% <85.71%> (-0.61%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dee9aa...16b72d5. Read the comment docs.

@likeamahoney likeamahoney force-pushed the feature/net-alias-duplication-check branch from 49d4723 to 16b72d5 Compare July 12, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant