Fix a bug in the tidy-check UnusedSensitiveSignal #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new check enforces that each always_comb block is named
This new check enforces that each generate block is named. This also is applied to the for block
This check ensures that no module instantiation uses the sintax '.var' in the port connection, and ensures that '.var(var)' is used instead
Now, when '.*' is used with the NoDotStarInPortConnection check enabled, the warning will be located where the '.*' character is, instead of the location of the module that was being called.
This new check enforces that no generate block is used in the code, since it is an old system verilog syntax
This new synthesis check ensures that if there is a conditional block with reset, all the assignments must be either inside the if or else statements.
This new check verifies that every signal inside the sensitivity list of an 'always' or 'always_ff' block is used inside the block statement. The only exception is the clock signal
* slang-tidy fix OnlyAssignedOnReset and RegisterHasNoReset: This commit will ensure that both checks will no longer be ignoring the configuration setting 'resetIsActiveHigh' and the possible negation of the reset signal. Two test cases have also been added to consider this bug. * The error location of the warnings generated by the OnlyAssignedOnReset and RegisterHasNoReset are now more precise and target the variable instance where the error is found instead of the variable declaration.
…slang into dev/slang-tidy * 'dev/slang-tidy' of https://github.com/JoelSole-Semidyn/slang: style: pre-commit fixes
Added a simple fix to ensure that the body kind is the correct one when accessing the body attributes
…dev/slang-tidy * 'master' of https://github.com/MikePopoloski/slang: Update CHANGELOG.md [slang] Fix PLA task concatenation ascending order (MikePopoloski#1047) [slang] Fix PATHPULSE limit values (MikePopoloski#1048) Handle recursive parameter definitions via hierarchical reference Mark fmt lib headers as system headers to suppress warnings Bump dependency versions: fmt and pybind11 [slang] Make string simple type (MikePopoloski#1049) Update README.md (MikePopoloski#1046) [slang][port] Fix bugs (MikePopoloski#1043) Use [[likely]] / [[unlikely]] replace macro SLANG_LIKELY/SLANG_UNLIKELY (MikePopoloski#1038) Add multiple slang-tidy checks and minor fixes in existing ones (MikePopoloski#1040) chore: update pre-commit hooks (MikePopoloski#1041)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1056 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 191 191
Lines 47664 47664
=======================================
Hits 45144 45144
Misses 2520 2520 Continue to review full report in Codecov by Sentry.
|
|
I think a test case proving the fix is needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple fix to ensure that the body kind is the correct one when accessing the body attributes