-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new features to slang-tidy #777
Conversation
Added possibility to configure enabled tests with a config file Added some new tests
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #777 +/- ##
==========================================
+ Coverage 91.51% 92.60% +1.09%
==========================================
Files 188 188
Lines 45544 45579 +35
==========================================
+ Hits 41678 42208 +530
+ Misses 3866 3371 -495
... and 42 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
You shouldn't need the SLANG_EXPORT tag on anything in the tidy binary, it's only for library symbols. I suspect the problem might be from not_null being tagged even though it's a template class. I'm going to experiment with removing it and seeing if that helps. |
Removed, thanks for taking a look at it |
Ok, I committed a potential fix, try rebasing. |
It did the trick, thanks. Ready to be merged if you don't see anything sketchy on the code |
Created an object library for the different components of slang-tidy: checks and config parser. This way these cpp files are not compiled twice for the binary and for the tests.
This PR adds new features to slang-tidy:
This PR also adds a new tool:
include/slang/util/CppTypePrinter.h