Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple slang-tidy port suffixes for EnforcePortSuffix check #787

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

VJSchneid
Copy link
Contributor

@VJSchneid VJSchneid commented Jul 10, 2023

Hi folks,
this PR makes the following modifications in slang-tidy:

  • Adds support to provide an array of configuration values in the slang-tidy config file ([_i, _ni]).
  • Multiple (or none) port suffixes can be specified now. This enables e.g. negated ports to be specified as _ni when both _i and _ni are configured as port suffixes.
  • Parsing of configValues was slightly rewritten to allow flexible parsing depending on targeted type.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #787 (c4f847b) into master (02e2354) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #787   +/-   ##
=======================================
  Coverage   93.56%   93.57%           
=======================================
  Files         189      189           
  Lines       45650    45685   +35     
=======================================
+ Hits        42714    42748   +34     
- Misses       2936     2937    +1     

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e2354...c4f847b. Read the comment docs.

@MikePopoloski
Copy link
Owner

Thanks for the PR. I skimmed this and it looks ok to me so I'm going to merge. @Sustrak should reply as well if he thinks there are things worth changing here.

@MikePopoloski MikePopoloski merged commit 05f4678 into MikePopoloski:master Jul 12, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants