Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-370: Fix spy on function with return type Varaiant #371

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Conversation

MikeSchulze
Copy link
Owner

Why

Spy on a function with return type Variant was wrong doubled and has return always nothing.

What

  • Check the usage flag of the return descriptor and check for PROPERTY_USAGE_NIL_IS_VARIANT to determine it is a Variant
  • Add missing reflection of Variant type
  • Add missing flag PROPERTY_USAGE_NIL_IS_VARIANT

# Why
Spy on a function with return type `Variant` was wrong doubled and has return always nothing.


# What
- Check the usage flag of the return descriptor and check for `PROPERTY_USAGE_NIL_IS_VARIANT` to determine it is a `Variant`
- Add missing reflection of Variant type
- Add missing flag `PROPERTY_USAGE_NIL_IS_VARIANT`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GD-370: Spy on a function with return type Variant does return any value
1 participant