Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-204: Minior update on contributing page #214

Merged
merged 6 commits into from Jun 19, 2023
Merged

GD-204: Minior update on contributing page #214

merged 6 commits into from Jun 19, 2023

Conversation

MikeSchulze
Copy link
Owner

Why

What

@MikeSchulze MikeSchulze self-assigned this Jun 16, 2023
@MikeSchulze MikeSchulze linked an issue Jun 16, 2023 that may be closed by this pull request
@clemens-tolboom
Copy link
Contributor

clemens-tolboom commented Jun 16, 2023

LGTM :-)

I miss the direct linking to the steps but that is your call.

Maybe mention your numbering convention on issue titles?

And maybe add you project(s) page https://github.com/users/MikeSchulze/projects/ ?

@MikeSchulze
Copy link
Owner Author

MikeSchulze commented Jun 16, 2023

@clemens-tolboom

I miss the direct linking to the steps but that is your call.

a link from where?

And you project(s) page https://github.com/users/MikeSchulze/projects/ ?

what you mean in detail?
The PR has no affect to the projects, only issues are linked to projects

@clemens-tolboom
Copy link
Contributor

I somehow did not get notification on this or just missed it.

Yours

a link from where?

I can link to https://github.com/MikeSchulze/gdUnit4/blob/master/CONTRIBUTING.md#github-flow but not on the list items. If you change

  1. Select an open issue to work on or create a new issue if none exists.

into H3

Select an open issue to work on or create a new issue if none exists.

you can friendly point a user to that bullet

Your

what you mean in detail?

This PR is to teach your users ... maybe they want to discover your project too. But that can go into the README.md better?

@MikeSchulze
Copy link
Owner Author

I somehow did not get notification on this or just missed it.

Yours

a link from where?

I can link to https://github.com/MikeSchulze/gdUnit4/blob/master/CONTRIBUTING.md#github-flow but not on the list items. If you change

  1. Select an open issue to work on or create a new issue if none exists.

into H3

Select an open issue to work on or create a new issue if none exists.

you can friendly point a user to that bullet

Your

what you mean in detail?

This PR is to teach your users ... maybe they want to discover your project too. But that can go into the README.md better?

there is a link already in the README.md to the contribution.md ;)

I somehow did not get notification on this or just missed it.

Yours

a link from where?

I can link to https://github.com/MikeSchulze/gdUnit4/blob/master/CONTRIBUTING.md#github-flow but not on the list items. If you change

  1. Select an open issue to work on or create a new issue if none exists.

into H3

Select an open issue to work on or create a new issue if none exists.

you can friendly point a user to that bullet

Your

what you mean in detail?

This PR is to teach your users ... maybe they want to discover your project too. But that can go into the README.md better?

there is already a link in the README.md to the contribution page. I do not want to link to a specific part of the contribution page. A user should read from beginning ;)

@MikeSchulze MikeSchulze merged commit dcd6c40 into master Jun 19, 2023
@MikeSchulze MikeSchulze deleted the GD-204-2 branch June 19, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GD-204: CONTRIBUTE.md misses the wished workflow AND has wrong link
2 participants