Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-343: Fix .NET: Failed to unload assemblies error when unload the plugin #344

Merged
merged 3 commits into from
Feb 10, 2024

Conversation

MikeSchulze
Copy link
Owner

@MikeSchulze MikeSchulze commented Feb 10, 2024

Why

Some GdUnit4 users reported these errors on discord -> https://discordapp.com/channels/885149082119733269/1201435634875764756

What

  • do not extend anymore from the gdunit assembly, we only load the class and use the static methods
  • rename classes from mono to csharp (mono is outdated)

@MikeSchulze MikeSchulze self-assigned this Feb 10, 2024
@MikeSchulze MikeSchulze changed the title GD-343: Fix .NET: Failed to unload assemblies error when unload the… GD-343: Fix .NET: Failed to unload assemblies error when unload the plugin Feb 10, 2024
… plugin

# Why
Some GdUnit4 users reported these errors on discord -> https://discordapp.com/channels/885149082119733269/1201435634875764756

# What
* do not extend anymore from the gdunit assembly, we only load the class and use the static methods
* rename classes from `mono` to `csharp` (mono is outdated)
@MikeSchulze MikeSchulze merged commit 1340d01 into master Feb 10, 2024
@MikeSchulze MikeSchulze deleted the GD-343 branch February 10, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GD-343: GdUnit4 unload issues when using Godot Mono .NET: Failed to unload assemblies.
1 participant