Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-8: Replace Vector2Assert and Vector3Assert by generic VectorAssert<T> #8

Closed
MikeSchulze opened this issue Jun 30, 2023 · 0 comments · Fixed by #45
Closed

GD-8: Replace Vector2Assert and Vector3Assert by generic VectorAssert<T> #8

MikeSchulze opened this issue Jun 30, 2023 · 0 comments · Fixed by #45
Assignees
@MikeSchulze
Labels
gdunit4.api Issue is related to the `gdunit4.api` Refactoring
Milestone
v4.2.1

Comments

@MikeSchulze
Copy link
Owner

A Task is not a bug or feature request

Description

Convert existing VectorXAsserts into a generic VectorAssert to support all Godot vector types

Acceptance criteria

  • add VectorAssert<T>
  • remove Vector2Assert
  • remove Vector3Assert
  • add integration tests for VectorAssert<T>
@MikeSchulze MikeSchulze added the enhancement New feature or request label Jun 30, 2023
@MikeSchulze MikeSchulze added this to the v4.2.0 milestone Jun 30, 2023
@MikeSchulze MikeSchulze self-assigned this Jun 30, 2023
@MikeSchulze MikeSchulze changed the title Replace Vector2Assert and Vector3Assert by generic VectorAssert<T> GD-8: Replace Vector2Assert and Vector3Assert by generic VectorAssert<T> Jun 30, 2023
@MikeSchulze MikeSchulze added GDScript2.0 An error based on GdScript2.0 renamings Refactoring and removed enhancement New feature or request labels Jun 30, 2023
@MikeSchulze MikeSchulze changed the title GD-8: Replace Vector2Assert and Vector3Assert by generic VectorAssert<T> GD-8: gdunit4.api Replace Vector2Assert and Vector3Assert by generic VectorAssert<T> Feb 25, 2024
@MikeSchulze MikeSchulze modified the milestones: v4.2.0, v4.2.1 Feb 25, 2024
@MikeSchulze MikeSchulze linked a pull request Feb 25, 2024 that will close this issue
G-8: Provide generic vector assert to support all Godot vector types #45
Merged
@MikeSchulze MikeSchulze added gdunit4.api Issue is related to the `gdunit4.api` and removed GDScript2.0 An error based on GdScript2.0 renamings labels Feb 28, 2024
@MikeSchulze MikeSchulze changed the title GD-8: gdunit4.api Replace Vector2Assert and Vector3Assert by generic VectorAssert<T> GD-8: Replace Vector2Assert and Vector3Assert by generic VectorAssert<T> Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeSchulze MikeSchulze

Labels
gdunit4.api Issue is related to the `gdunit4.api` Refactoring
Projects
None yet
Milestone
v4.2.1
Development

Successfully merging a pull request may close this issue.

G-8: Provide generic vector assert to support all Godot vector types MikeSchulze/gdUnit4Net
1 participant
@MikeSchulze