G-8: Provide generic vector assert to support all Godot vector types #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeSchulze
force-pushed
the
GD-8
branch
3 times, most recently
from
abafd0e
to
2aa4281
Compare
# Why We want to have one assert for all Godot vector types, actual we have only covered Vector2 and Vector3 # What - Removed the interfaces and implementations for Vector2 and Vector3 - Introduced IVectorAssert<T> and implementation - make the old asserts as deprecated. - removed the custom float and vector format - set explicit the culture to "en-us" to get expected failure messages in english notation - fix test name generation to use culture to "en-us" for parameter formattings
MikeSchulze
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to have one assert for all Godot vector types, actual we have only covered Vector2 and Vector3
What