Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-12: Reorganize the project #15

Merged
merged 10 commits into from
Jul 29, 2023
Merged

GD-12: Reorganize the project #15

merged 10 commits into from
Jul 29, 2023

Conversation

MikeSchulze
Copy link
Owner

Why

We want to split between API and test coverage to only include the API in the nuget packages It should be possible to run the test without project modifications from root project

What

  • split the project into api and test

# Why
We want to split between API and test coverage to only include the API in the nuget packages
It should be possible to run the test without project modifications from root project


# What
- split the project into `api` and `test`
RubenHuizenga and others added 4 commits July 25, 2023 08:28
The file paths still included the test folder, but that does not exist in the project anymore.
… added null checks

Added a src folder to the test project to separate the code from the other files. Removed using directives that were unused and  added some null checks in TestSuite.cs
Copy link
Owner Author

@MikeSchulze MikeSchulze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Yes to move the test code into a src folder makes sense.
And nice cleanup.

api/src/core/execution/TestSuite.cs Show resolved Hide resolved
test/src/core/GdUnitTestSuiteBuilderTest.cs Outdated Show resolved Hide resolved
@MikeSchulze MikeSchulze marked this pull request as ready for review July 27, 2023 19:13
@MikeSchulze MikeSchulze added the enhancement New feature or request label Jul 27, 2023
@MikeSchulze MikeSchulze merged commit 8e779cf into master Jul 29, 2023
@MikeSchulze MikeSchulze deleted the GD-12 branch July 29, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GD-12: Rebuilding the project by splitting it into library and test projects
2 participants