Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-10: Complete missing features for IEnumerableAssert #69

Merged
merged 1 commit into from
Mar 27, 2024
Merged

GD-10: Complete missing features for IEnumerableAssert #69

merged 1 commit into from
Mar 27, 2024

Conversation

MikeSchulze
Copy link
Owner

@MikeSchulze MikeSchulze commented Mar 24, 2024 •
edited
Loading

Why

The API differs between GDScript and C# and needs to be reconciled.

What

  • improve messages on AssertFailures to accept generic types
  • fix formatting issues for IEnumerables
  • fix test case name building by using TestCase.BuildTestCaseName discovered after fixing the IEnumerables formattings
  • rebuild IEnumerableAssert to make it generic
    • ContainsSame ✅
    • ContainsSameExactly ✅
    • ContainsSameExactlyInAnyOrder ✅
    • IsNotSame ✅
    • IsSame ✅
    • NotContains ✅
    • NotContainsSame ✅

@MikeSchulze MikeSchulze self-assigned this Mar 24, 2024
@MikeSchulze MikeSchulze linked an issue Mar 24, 2024 that may be closed by this pull request
GD-10: Complete missing features from GdUnit4 GdScript asserts #10
Closed
@MikeSchulze MikeSchulze changed the title GD-10: Rework on IEnumerableAssert GD-10: Complete missing features for IEnumerableAssert Mar 24, 2024
@MikeSchulze MikeSchulze force-pushed the GD-10-2 branch 2 times, most recently from 9515ac4 to 7ea2e19 Compare March 25, 2024 10:27
@MikeSchulze MikeSchulze added gdunit4.api Issue is related to the `gdunit4.api` gdunit4.test.adapter This issue is related to `gdunit4.test.adapter` labels Mar 25, 2024
@MikeSchulze MikeSchulze force-pushed the GD-10-2 branch 8 times, most recently from a3fc8d5 to 7d0f1ee Compare March 27, 2024 08:48
@MikeSchulze MikeSchulze marked this pull request as ready for review March 27, 2024 08:50
@MikeSchulze MikeSchulze force-pushed the GD-10-2 branch 3 times, most recently from c84b762 to 7ecf772 Compare March 27, 2024 08:59
GD-10: Rework on IEnumerableAssert
5b8fefe 
# Why
We miss some verification methods and needs to be completed.

# What
- rebuild `IEnumerableAssert` to make it generic
- improve messages on `AssertFailures` to accept generic types
- addd `IsSame`
@MikeSchulze MikeSchulze merged commit c1a8d33 into master Mar 27, 2024
@MikeSchulze MikeSchulze deleted the GD-10-2 branch March 27, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MikeSchulze MikeSchulze

Labels
gdunit4.api Issue is related to the `gdunit4.api` gdunit4.test.adapter This issue is related to `gdunit4.test.adapter`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GD-10: Complete missing features from GdUnit4 GdScript asserts
1 participant
@MikeSchulze