GD-74: Improve the CI workflow for job unit-test-example by validate the test report
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeSchulze
force-pushed
the
GD-74
branch
22 times, most recently
from
6e1464b
to
d65c846
Compare
…e the test report # Why The current job unit-test-example executes the test and forces the step to always end with success. We have done this so as not to interrupt the job. But we forgot a validation step right after the test results that checks the expected test results. # What - fixed actions to publish and upload test reports to include the examples result. - add validation step to verify for expected test results
…e the test report # Why The current job unit-test-example executes the test and forces the step to always end with success. We have done this so as not to interrupt the job. But we forgot a validation step right after the test results that checks the expected test results. # What - fixed actions to publish and upload test reports to include the examples result. - add validation step to verify for expected test results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The current job unit-test-example executes the test and forces the step to always end with success. We have done this so as not to interrupt the job.
But we forgot a validation step right after the test results that checks the expected test results.
What
unit-test-exampleto verify for expected test results.CheckGdUnit4ApiVersionto utilies to reuse onGdUnit4TestExecutor