add permission for enableLink #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnsmichi
reviewed
Mar 19, 2018
configuration.php
Outdated
| @@ -6,6 +6,7 @@ | |||
| $this->providePermission('grafana/graphconfig', $this->translate('Allow to configure graphs.')); | |||
| $this->providePermission('grafana/debug', $this->translate('Allow to see module debug informations.')); | |||
| $this->providePermission('grafana/showall', $this->translate('Allow access to see all graphs of a host.')); | |||
| $this->providePermission('grafana/enableLink', $this->translate('Enable link to grafana')); | |||
There was a problem hiding this comment.
I‘d suggest to keep permissions lowercase.
I would also do that for the config setting, but that‘s for a different issue.
dnsmichi
reviewed
Mar 19, 2018
| @@ -511,7 +511,7 @@ public function getPreviewHtml(MonitoredObject $object, $report = false) | |||
| $res = $this->getMyPreviewHtml($serviceName, $hostName, $previewHtml); | |||
|
|
|||
| //do not render URLs on error or if disabled | |||
| if (!$res || $this->enableLink == "no") { | |||
| if (!$res || $this->enableLink == "no" || !$this->permission->hasPermission('grafana/enableLink')) { | |||
There was a problem hiding this comment.
Is that condition really correct?
|
Please lowercase the permissions as @dnsmichi suggested and i will add it. |
|
ok, the permission name ist now enable-link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please add a permission to enable the link just for some roles