Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use icinga color for timerange menu #62

Merged
merged 1 commit into from
May 25, 2017

Conversation

epinter
Copy link
Contributor

@epinter epinter commented May 23, 2017

No description provided.

@Mikesch-mp
Copy link
Owner

Hello Emerson,

the color i use is the Icinga blue. And i want the color change on mouseover!

Best regards,

@Mikesch-mp Mikesch-mp closed this May 24, 2017
@epinter
Copy link
Contributor Author

epinter commented May 24, 2017

When you try to use another theme that use another color that is not blue, you will need this change...

@dnsmichi
Copy link
Collaborator

I'm not a CSS guru, but @icinga-blue would reference the framework's css which is then resolved by the less compiler, or so. I think @epinter 's patch is more correct than hardcoding a color code in a module's css, but I need to test the patch when I get time :)

@Mikesch-mp
Copy link
Owner

Mikesch-mp commented May 24, 2017

I tested it and @epinter is right with the @icinga-color. With this it will change to whatever the color is in the actual theme.

@epinter please edit your change to this code and then i will add the pull request.

.grafana-menu-navigation:hover a.main {
  color: @body-bg-color;
  background: @icinga-blue;
}

@Mikesch-mp
Copy link
Owner

Ahh and for future prull request, give please a litle description what the change shold do. iam only a stupid developer and it takes a lot of time to understand the pull requests.

@Mikesch-mp Mikesch-mp reopened this May 24, 2017
@Mikesch-mp Mikesch-mp added this to the 1.1.6 milestone May 24, 2017
@epinter
Copy link
Contributor Author

epinter commented May 24, 2017

Do you mind if I use this ? I think is makes more sense and the result is the same (background blue and white text).

.grafana-menu-navigation:hover a.main {
color: @text-color-inverted;
background-color: @icinga-blue;
}

@epinter epinter force-pushed the for-upstream/cssmenucolor branch from 2ab8c55 to 46df405 Compare May 24, 2017 19:02
@epinter epinter force-pushed the for-upstream/cssmenucolor branch from 46df405 to e867940 Compare May 24, 2017 19:04
@Mikesch-mp
Copy link
Owner

Thats even better :)

@Mikesch-mp Mikesch-mp merged commit e867940 into Mikesch-mp:master May 25, 2017
@epinter epinter deleted the for-upstream/cssmenucolor branch June 5, 2017 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants