We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to parse the following URL causes the wrong result
var feed = new Url('https://www.google.com/calendar/feeds/test/private-t42423424234/full?start-index=1&max-results=20'); feed.toString() ->> returns "https://www.google.com:443calendar/feeds/test/private-t42423424234/full?start-index=1&max-results=20"
There are two problems:
I have fixed it by changing toString() function to the following. Haven't tested it in all scenarios, by with full URL works fine
this.toString = function () { return ( (this.protocol && (this.protocol + '://')) + (this.user && (this.user + (this.pass && (':' + this.pass)) + '@')) + (this.host && this.host) + ((this.port && !(this.port == 443 && this.protocol == 'https') && !(this.port == 80 && this.protocol == 'http')) ? this.port : '') + (this.path && ('/' + this.path)) + (this.query.toString() && ('?' + this.query)) + (this.hash && ('#' + this.hash)) ); };
The text was updated successfully, but these errors were encountered:
Which browser do you use? I've tested under:
Works well, bug described above is not reproduced.
Sorry, something went wrong.
IE 9
Sent from my iPhone
On May 6, 2013, at 1:24 PM, Mykhailo Stadnyk notifications@github.com wrote:
What is the browser do you use? I've tested under Chrome 26, it works well, bug described above is not reproduced. — Reply to this email directly or view it on GitHub.
What is the browser do you use? I've tested under Chrome 26, it works well, bug described above is not reproduced.
— Reply to this email directly or view it on GitHub.
OK, as expected :D, I'll try but it's a bit problematic for the moment as far as I'm on Linux...
Fixed issue #2 - Compatibility problem with IE 9
3ffebb3
Fixed IE compatibility - pack2, commit fixes issue #2
48a2d91
Mikhus
No branches or pull requests
Attempt to parse the following URL causes the wrong result
var feed = new Url('https://www.google.com/calendar/feeds/test/private-t42423424234/full?start-index=1&max-results=20');
feed.toString() ->> returns
"https://www.google.com:443calendar/feeds/test/private-t42423424234/full?start-index=1&max-results=20"
There are two problems:
I have fixed it by changing toString() function to the following. Haven't tested it in all scenarios, by with full URL works fine
this.toString = function () {
return (
(this.protocol && (this.protocol + '://')) +
(this.user && (this.user + (this.pass && (':' + this.pass)) + '@')) +
(this.host && this.host) +
((this.port && !(this.port == 443 && this.protocol == 'https') && !(this.port == 80 && this.protocol == 'http')) ? this.port : '') +
(this.path && ('/' + this.path)) +
(this.query.toString() && ('?' + this.query)) +
(this.hash && ('#' + this.hash))
);
};
The text was updated successfully, but these errors were encountered: