docs: Fixed typo #18
Merged
docs: Fixed typo #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miksus
requested changes
Jan 19, 2022
There was a problem hiding this comment.
Thanks for your contribution and for spotting this mistake! I searched the codebase if I had made a similar mistake elsewhere and I realized the EmailSender's method send docstring has the same issue also (probably copy-pasted from this specific example).
Would you be able to fix this also in this PR? The issue is here: https://github.com/Miksus/red-mail/blob/master/redmail/email/sender.py#L236
In case not, I could also do it but I would like to bundle it with this change.
|
No worries at all, happy to help and thanks for a great tool! Hopefully the new commit closes this out for you. |
|
Yep, this looks good, thanks for this. And no problem, I'm happy you find it useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.