Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23 fix contenttype attachment #24

Merged
merged 2 commits into from
Jan 23, 2022
Merged

Conversation

Miksus
Copy link
Owner

@Miksus Miksus commented Jan 23, 2022

See: issue 23

@Miksus Miksus added the bug Something isn't working label Jan 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #24 (8aec193) into master (f19d4ca) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          12       12           
  Lines         494      494           
=======================================
  Hits          492      492           
  Misses          2        2           
Impacted Files Coverage Δ
redmail/email/attachment.py 100.00% <100.00%> (ø)
redmail/email/body.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19d4ca...8aec193. Read the comment docs.

@Miksus
Copy link
Owner Author

Miksus commented Jan 23, 2022

This works for without bodies, with text body, with HTML body and with text and HTML body (tested sent Gmail, viewed Gmail & Windows Mail app).

Seems at least the Windows Mail app does not like an email with an attachment and without text and HTML bodies (does not show the email has an attachment).

@Miksus Miksus merged commit 0a69f48 into master Jan 23, 2022
@Miksus Miksus deleted the 23-fix-contenttype-attachment branch January 23, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Fail on send with text body and attachments or only attachments (without body)
2 participants