Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Allow calling sender.close() multiple times #59

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

martino87r
Copy link
Contributor

Fixes an incorrect import in the tutorial section of the documentation

@martino87r martino87r changed the title Fix incorrect import in tutorial documentation Small fixes Oct 27, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 99.66% // Head: 99.66% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (850295f) compared to base (46908b1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files          10       10           
  Lines         589      590    +1     
=======================================
+ Hits          587      588    +1     
  Misses          2        2           
Impacted Files Coverage Δ
redmail/email/sender.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Miksus
Copy link
Owner

Miksus commented Oct 28, 2022

Ye, indeed. Thanks for spotting!

I was thinking about the close. Now it wouldn't raise an exception if the connection is already closed. Considering the python file buffer (ie. open("myfile.txt", "w")) does not raise an exception if the buffer is already closed, I think your change is appropriate.

@Miksus Miksus changed the title Small fixes FIX: Allow calling sender.close() multiple times Oct 28, 2022
@Miksus Miksus added bug Something isn't working documentation Improvements or additions to documentation labels Oct 28, 2022
@Miksus Miksus merged commit c5c57b4 into Miksus:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants