-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for PydanticV2 #212
base: master
Are you sure you want to change the base?
Commits on Jul 16, 2023
-
First commit for supporting pydanticV2
- Temporarily comment out RedBase session attribute as it was causing issues with re-writing the value - Converted update_forward_refs to model_rebuild in _setup.py - set type on mac_process_count in sessions.py - Implemented ClassVar when dealing with session variable to fix inheritence - Convert Config Meta Class into model_config attribute - set default values Task class as in pydanticv2 they were set to required=True as default - _delayed_kwargs now ClassVar to be passed correctly
Configuration menu - View commit details
-
Copy full SHA for f01e33d - Browse repository at this point
Copy the full SHA f01e33dView commit details
Commits on Jul 17, 2023
-
Moves to fix testing and continue migration
- run bump-pydantic script to make changes where applicable (Didn't seem to make that many changes) - fix session variable overwrite in test_core.py - add variable to root_validator (to get tests to run) but this needs migrating as root_validator is depreceated - test results: 43 failed, 1739 passed, 23 skipped, 8 xfailed, 3 xpassed, 17654 warnings
Configuration menu - View commit details
-
Copy full SHA for e78342d - Browse repository at this point
Copy the full SHA e78342dView commit details -
Migrated validator decorators to field_validators
- always=True is depreceated, alternate solution to set model config validate_defualt to True to force checking on default values (which were set as part of migration) - Had to apply some additional typing to allow for that setting (Mainly setting some Union None as well as callable values) - values argument passed into validators now has nested data attribute in class. Had to append .data to any call of values - fixed manual validator changes that the bump script couldn't do as well - test results: 44 failed, 1738 passed, 23 skipped, 8 xfailed, 3 xpassed, 17070 warnings
Configuration menu - View commit details
-
Copy full SHA for ff59fcd - Browse repository at this point
Copy the full SHA ff59fcdView commit details
Commits on Jul 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 79816e8 - Browse repository at this point
Copy the full SHA 79816e8View commit details
Commits on Jul 19, 2023
-
fix pickle tests and serialization
- convert json encoders to field_serialiser decorators for variables and replace .dict/.json with model_dump and model_dump_json - change __private_attribute_values__ query over to use __pydantic_private__ - tests now only fail due to weird inheritence issue when attempting to pass session into either FuncTask or Task - Not sure whats causing this issue - Tried to get arround it by setting a ClassVar in the test but this then doesn't pass the session variable into values in the validation decorators - test results at: 18 failed, 1764 passed, 23 skipped
Configuration menu - View commit details
-
Copy full SHA for 34b6caf - Browse repository at this point
Copy the full SHA 34b6cafView commit details
Commits on Jul 23, 2023
-
Convert task.py session attribute into class var to allow for some ki…
…nd of class inheritance with the variable - setting the value as None removed from RedBase - Still same issue with inheritence present within pydantic
Configuration menu - View commit details
-
Copy full SHA for 73e8bfc - Browse repository at this point
Copy the full SHA 73e8bfcView commit details
Commits on Jul 24, 2023
-
Implementing some suggested changes
- Remove brackes from RedBase, base function - Set cls_lock attribute to callable (Waiting for clarification) - validate_default in model config no longer necessary after testing - Changed daemon attribute from False to Nonw (Waiting for clarification) - _delayed_kwargs no longer a task variable
Configuration menu - View commit details
-
Copy full SHA for bbb5a37 - Browse repository at this point
Copy the full SHA bbb5a37View commit details -
Implement work around to partially intitialise pydantic class variabl…
…es to allow setting of self when setting _delayed_kwargs:O
Configuration menu - View commit details
-
Copy full SHA for 31f821f - Browse repository at this point
Copy the full SHA 31f821fView commit details
Commits on Jul 25, 2023
-
Commit to work on reducing some of the deprecation warnings
- in tests replace .dict statment with .model_dump - tidy up inport of _object_setter - Add setting (temporarily) into tox.ini to ignore deprecation warnings from redbird
Configuration menu - View commit details
-
Copy full SHA for 62ac9ab - Browse repository at this point
Copy the full SHA 62ac9abView commit details
Commits on Jul 26, 2023
-
- Implemented fix to DummyTask by having it as part of the application preventing inheritence error. - Added dummy task to __init__.py for rocketry.tasks and into the setup for ForwardRefs - Fixed test_meta by removing the classVar previously put in for the _FuncCondWrapper function - Some general tidy ups Test results at: 1 failed, 1781 passed, 23 skipped, 8 xfailed, 3 xpassed, 8707 warnings in 41.18s - The one failed test is likely to do with the way I'm using Virtualenv, as this is also present in the stable release of Rocketry on my machine
Configuration menu - View commit details
-
Copy full SHA for d00f98f - Browse repository at this point
Copy the full SHA d00f98fView commit details -
Removing some of the deprecation warnings related to .dict and root_h…
…andler removed temp pytest to ignore redbird warnings:
Configuration menu - View commit details
-
Copy full SHA for c3d8dbe - Browse repository at this point
Copy the full SHA c3d8dbeView commit details
Commits on Oct 6, 2023
-
Fix issues with pickling in multiprocess execution
- Not sure what changed but pickling stopped working again (maybe a recent update to pydantic again) - To resolve this had to add 'returns' to the pickled attributes set to None - This seems to have fixed the initial issues but has caused some tests to fail - Will begin debugging this again
Josh Pearson authored and Josh Pearson committedOct 6, 2023 Configuration menu - View commit details
-
Copy full SHA for 8e20def - Browse repository at this point
Copy the full SHA 8e20defView commit details
Commits on Oct 8, 2023
-
Fixed pickling for the most part, but the test_nested params test in …
…post materilising seems to fail. Not sure if this is no longer possible in the new version
Josh Pearson authored and Josh Pearson committedOct 8, 2023 Configuration menu - View commit details
-
Copy full SHA for e94f1c8 - Browse repository at this point
Copy the full SHA e94f1c8View commit details