Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Return function argument in documentation #27

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

addisonhardy
Copy link
Contributor

  • Updated the function name passed to Return in the code documentation from do_on_process -> do_daily.
  • I've enjoyed testing out the library. Thanks for releasing!

@gaby
Copy link

gaby commented Jul 4, 2022

I think the same documentation bug is present in the advanced.py tutorial form the same folder.

@Miksus Miksus added the documentation Improvements or additions to documentation label Jul 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #27 (7d2ab88) into master (ba26ec2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files          81       81           
  Lines        3652     3652           
=======================================
  Hits         3289     3289           
  Misses        363      363           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba26ec2...7d2ab88. Read the comment docs.

@Miksus
Copy link
Owner

Miksus commented Jul 4, 2022

Thanks for the contribution! Sometimes I had a hard time inventing the examples and it's good to have another pair of eyes to actually validate those.

@Miksus Miksus merged commit 2173610 into Miksus:master Jul 4, 2022
@addisonhardy addisonhardy deleted the docs/rename-func-arg branch August 10, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants